Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication to webhooks #2389

Open
mrPsycho opened this issue Nov 15, 2018 · 5 comments
Open

Add authentication to webhooks #2389

mrPsycho opened this issue Nov 15, 2018 · 5 comments
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature.

Comments

@mrPsycho
Copy link

mrPsycho commented Nov 15, 2018

Is your feature request related to a problem? Please describe.
In addition to #1242 it would be great to have authentication option for webhooks.
or, maybe, just whitelist.

Describe the solution you'd like
would be great to use X-Gitlab-Token for validation

@nijel nijel added the enhancement Adding or requesting a new feature. label Nov 15, 2018
@nijel
Copy link
Member

nijel commented Nov 15, 2018

I was thinking about that as well. The token would have to be stored per project though to avoid leaking it across projects on shared instances.

@vladox
Copy link
Contributor

vladox commented May 7, 2020

@nijel do you accept PR regarding this feature?

@nijel
Copy link
Member

nijel commented May 7, 2020

Patches are always welcome :-). It just have to be opt-in feature to avoid breaking existing setups.

@nijel nijel added the backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. label Oct 7, 2020
@github-actions
Copy link

github-actions bot commented Oct 7, 2020

This issue has been added to the backlog. It is not scheduled on our roadmap, but it eventually might be implemented. In case you desperately need this feature, please consider helping or funding the development.

@nijel
Copy link
Member

nijel commented Oct 7, 2020

This doesn't have a high priority as Weblate doesn't use much from the payload - at most it can trigger matching repository update based on the payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants