[XLIFF] Translations aren't being saved as Target in bilingual files

[XVII]

Describe the bug
I've noticed my Target translation files (bilinguals) are only getting their Source updated -- not the Target.

Maybe this is a regression introduced from #2521?

I need to test in 3.5 without patches.

To Reproduce

1. Using https://github.com/WeblateOrg/weblate/files/2853605/TranslationTest.zip
2. Translate en-NZ "Color" to "Colour"
3. Commit

Expected behavior
The en-NZ bilingual file should have the <Source>Color</Source> and <Target>Colour</Target> but instead my <Source> gets updated to "Colour".

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[nijel]

Before b21089b only target was updated, after it only source is updated. That was what you've described in #2521 - "should only update Source".

[XVII]

Yes, but only in the monolingual file (i.e. en-US to en-US) not the bilingual one (en-US to nl-NL).

The above is a bilingual example.

[nijel]

The source is updated only on monolingual translations (when monolingual template is set)...

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[XVII]

If that's the case then it shouldn't be affecting my bilingual files. Would a screen share or similar be useful here?

[nijel]

Is your translation configured as bilingual? Looking at the zip, I saw the .mono file and assumed you're using the monolingual setup...

[XVII]

Monolingual

Translation Test.mono.xlf is the monolingual base/source file (en-US).
It shouldn't have <Target>, just <Source>.

Bilingual

Translation Test.en-NZ.xlf is the bilingual translation file (en-US to en-NZ).
Translation Test.en-AU.xlf is the bilingual translation file (en-US to en-AU).
Both of these should have <Target> (matching up to the mono file), and<Source>.

[nijel]

I meant how it's configured in Weblate? Didn't you set monolingual base even for bilingual translation?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[XVII]

This can be closed and moved into #2668
Same issue.