Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spammer management #3548

Closed
surli opened this issue Mar 2, 2020 · 7 comments
Closed

Spammer management #3548

surli opened this issue Mar 2, 2020 · 7 comments
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. duplicate Similar issue or pull request already exists. enhancement Adding or requesting a new feature.

Comments

@surli
Copy link
Contributor

surli commented Mar 2, 2020

Is your feature request related to a problem? Please describe.
Our weblate instance is open to any contributor, which means that we have from time to time users trying to spam us by injecting wrong translations. I'm not talking about automatic spam here, more about users having fun in putting manually wrong translations.

Describe the solution you'd like
Would be nice to have an admin option allowing at the same time to block an user for further logging (without deleting him) and revert all his translations at once.
Note that in my recent case, the user actually created a new language so I wasn't able to use the "revert" option from UI for his translation: I had to manually save an empty translation.

Describe alternatives you've considered
Right now I performed the following:

  • opened the user profile to see all his changes
  • revert manually all the translations (by removing the translation, saving and dismissing the check)
  • go in Django admin to mark the user as not active.

Additional context
We are still using Weblate 3.9.1, I did not checked properly so maybe there's already some options for it now.

@nijel nijel added the question This is more a question for the support than an issue. label Mar 2, 2020
@nijel
Copy link
Member

nijel commented Mar 2, 2020

Reverting the changes in Git might be easier and less error prone. But you will still run into troubles if somebody has changed the strings meanwhile. That's also reason why one click of reverting all changes won't be that easy.

Setting the user as not active should do the right thing in this case, though it won't prevent malicious user to register with another email.

@surli
Copy link
Contributor Author

surli commented Mar 2, 2020

Reverting the changes in Git might be easier and less error prone.

Actually we are working with pull requests: so what happens is that we closed the PR, but it kept being opened back by Weblate until I decided to rollback the change in Weblate. Which makes sense IMO: for me the process should be:

  • a user perform a translation
  • we review the change in PR
  • if it happens it's a spam, we close the PR and ban the user from Weblate

We especially don't want to accept the PR and revert it after because:

  1. it will remains in Weblate memory which is not good
  2. the spammer will appear in our authors, and we don't really want that :)

@nijel
Copy link
Member

nijel commented Mar 2, 2020

If you generate list of authors on Weblate, even reverted edits count for that. Similarly, with translation memory - reverting the change doesn't make the translation memory make go away.

Right now the easiest approach to deal with this is on git level. Either revert the commit ot rewrite history to skip it.

Having something in Weblate might be useful, but doing this properly is not that easy.

@nijel nijel added backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature. and removed question This is more a question for the support than an issue. labels Mar 2, 2020
@github-actions
Copy link

github-actions bot commented Mar 2, 2020

This issue has been added to backlog. It is not scheduled on our road map, but it might be eventually implemented. In case you desperately need this feature, please consider helping or funding the development.

@nijel
Copy link
Member

nijel commented Mar 4, 2020

Duplicate of #3040

@nijel nijel marked this as a duplicate of #3040 Mar 4, 2020
@nijel nijel closed this as completed Mar 4, 2020
@nijel nijel added the duplicate Similar issue or pull request already exists. label Mar 4, 2020
@WeblateOrg WeblateOrg deleted a comment from github-actions bot Mar 4, 2020
@nijel
Copy link
Member

nijel commented Mar 4, 2020

Turns out this has been already reported...

@surli
Copy link
Contributor Author

surli commented Mar 4, 2020

Indeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. duplicate Similar issue or pull request already exists. enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants