Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zen editing does not save "needs editing" flag, because "has been translated" #4286

Closed
comradekingu opened this issue Aug 8, 2020 · 4 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@comradekingu
Copy link
Contributor

comradekingu commented Aug 8, 2020

This turned out "has been translated"
https://hosted.weblate.org/translate/xwords/android/nb_NO/?checksum=6186f2a953e1a08

What happens otherwise is the translation saved, but the "needs editing" checkbox not.
If that happens it says "Translation exists" or somesuch.

Could be these are two different issues?

Will have to see if it also hapens when not translating source strings with multiple tabs open in Zen and regular mode.

@comradekingu comradekingu changed the title Zen editing either fails saving "needs editing" flag, or raises "has been translated" Zen editing does not save "needs editing" flag, because "has been translated" Aug 8, 2020
@nijel
Copy link
Member

nijel commented Aug 8, 2020

I see it now saved as needs editing. Did you save it again? In case of failing check the string is saved, but the failing check is shown.

@comradekingu
Copy link
Contributor Author

comradekingu commented Aug 8, 2020

Yes. I went into the regular editor and did that.

Just now I opened an e-mail by clicking the "not translated strings" link
https://hosted.weblate.org/translate/openrefine/database/nb_NO/?q=state:empty

This string opened in the regular editor
https://hosted.weblate.org/translate/openrefine/database/nb_NO/?checksum=a736aceb92aeebaf
Then I changed to Zen mode
https://hosted.weblate.org/zen/openrefine/database/nb_NO/?q=state%3Aempty
Edited the string and clicked "needs editing"
it says

Translation of string has changed meanwhile: Please review your changes

"Needs editing" is not saved, but the string is.

@nijel
Copy link
Member

nijel commented Aug 18, 2020

Seems like a race condition, but I'm unable to trigger it. The edited string is saved ansynchronously once the textarea looses focus. The response updates string version in the browser. However before this happens, the string is submitted again with changed state and outdated version.

@nijel nijel self-assigned this Aug 18, 2020
@nijel nijel added the bug Something is broken. label Aug 18, 2020
@nijel nijel added this to the 4.2 milestone Aug 18, 2020
@nijel nijel closed this as completed in 3973bf3 Aug 18, 2020
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants