Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change base file or template from one repository to another #4535

Closed
comradekingu opened this issue Sep 17, 2020 · 5 comments
Closed
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@comradekingu
Copy link
Contributor

On https://hosted.weblate.org/settings/strongbox/translations/#vcs I accidentally set it up to point to
https://github.com/strongbox-password-safe/Strongbox at first

Then it was changed to https://github.com/strongbox-password-safe/babel
where the structure is different, so the filemask and monolingual base file failed, and it couldn't be changed to

Filemask: StrongBox/*.lproj/Localizable.strings
and
Template for new translations: StrongBox/Localizable.strings

Basically it can't be set up like https://hosted.weblate.org/settings/strongbox/strongbox/#files
without recreating the component.

Not sure if the StrongBox component should use template, basefile for monolingual or both, but that is another matter(?)

"de" was started as a translation in the translation component before trying to switch it over, if that makes any difference.

@nijel
Copy link
Member

nijel commented Sep 18, 2020

Why it could not be changed? Did you get some error?

@comradekingu
Copy link
Contributor Author

https://hosted.weblate.org/settings/strongbox/translations/#files

I did it now and got
"File does not exist" using "StrongBox/Localizable.strings" in "monolingual base file.
"Base file for new translations not found." if I put it in "Template for new translations"

You can try it. The component is just there for debugging at this point, and the "StrongBox" one is the one used.

It isn't the end of the world, but it helps to have a bug-report that someone can find I thought.

@nijel
Copy link
Member

nijel commented Sep 18, 2020

The problem is that these repositories do not have common history. In that case, changing the repo URL is not enough as that just leads to a merge error, but you have to do repository reset manually (in https://hosted.weblate.org/projects/strongbox/translations/#repository).

I'm not sure what's the best approach here. Weblate could just reset to the new upstream repo, but that would lead to losing anything done so far, that's why it's currently not done automatically.

@nijel nijel self-assigned this Sep 18, 2020
@nijel nijel added the enhancement Adding or requesting a new feature. label Sep 18, 2020
@nijel nijel added this to the 4.3 milestone Sep 18, 2020
@nijel
Copy link
Member

nijel commented Sep 18, 2020

I will add a warning about this situation to the settings page, so that user can be aware of this.

@nijel nijel closed this as completed in 420524c Sep 18, 2020
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants