Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template for new translations => Unrecognized base file for new translations #4828

Closed
myii opened this issue Nov 6, 2020 · 5 comments
Closed
Assignees
Labels
bug Something is broken.
Milestone

Comments

@myii
Copy link
Contributor

myii commented Nov 6, 2020

Describe the bug

After scanning my repo (https://gitlab.com/myii/ut-tweak-tool), it correctly finds the .pot file (po/ut-tweak-tool.sverzegnassi.pot) but then results in this error when attempting to save:

Unrecognized base file for new translations.

Filename of file used for creating new translations. For gettext choose .pot file.
  • I'm wondering whether it's having trouble with the second period (.).

To Reproduce the bug

Description should look similar to this:

Steps to reproduce the behavior:

As described above.

Expected behavior

po/ut-tweak-tool.sverzegnassi.pot should be accepted as a valid .pot file.

Screenshots

N/a.

Server configuration and status

Weblate deploy checks

Exception traceback

Additional context

Add any other context about the problem here.

@nijel
Copy link
Member

nijel commented Nov 7, 2020

It fails with following error:

Syntax error on line 1073

But Weblate should report this to user instead of just showing it in the logs...

@nijel nijel self-assigned this Nov 7, 2020
@nijel nijel added the bug Something is broken. label Nov 7, 2020
@nijel nijel added this to the 4.4 milestone Nov 7, 2020
@nijel nijel closed this as completed in 1435729 Nov 7, 2020
@github-actions
Copy link

github-actions bot commented Nov 7, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@myii
Copy link
Contributor Author

myii commented Nov 8, 2020

@nijel I still don't see any further error messages when attempting to save. In any case, the bug I've reported here is still unresolved:

  • po/ut-tweak-tool.sverzegnassi.pot should be accepted as a valid .pot file.

@nijel
Copy link
Member

nijel commented Nov 8, 2020

should be accepted as a valid .pot file.

No, because it isn't - the entries should be separated by whitespace lines, but the obsolete entries in your file aren't. See https://www.gnu.org/software/gettext/manual/html_node/PO-Files.html for syntax documentation.

What was fixed is displaying of the error message.

I still don't see any further error messages when attempting to save.

It was fixed in git and is not yet part of any release. In case you are using Hosted Weblate service (it would be nice to mention that), it was not yet deployed.

@myii
Copy link
Contributor Author

myii commented Nov 9, 2020

should be accepted as a valid .pot file.

No, because it isn't - the entries should be separated by whitespace lines, but the obsolete entries in your file aren't. See https://www.gnu.org/software/gettext/manual/html_node/PO-Files.html for syntax documentation.

Thanks, corrected this and now it's working (hosted Weblate service). I ended up using Dennis to confirm I'd cleared all of the violations. I was going to suggest mentioning that somewhere for end users but then I saw the conversation at #1252. I suppose that fix 1435729 will provide the lint error, so won't be an issue when that drops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants