Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role's permissions to "use machine translation services" and "use translation memory" does not work on source string #4838

Closed
rhofer opened this issue Nov 9, 2020 · 1 comment
Assignees
Labels
bug Something is broken.
Milestone

Comments

@rhofer
Copy link
Contributor

rhofer commented Nov 9, 2020

Describe the bug

With my instance of Weblate I set-up a generic role Basic Permissions to which all permitted users are onboarded at first. This should allow to:

  • Do suggestions > Permission: Add suggestion
  • Post comments > Permission: Post comment
  • Use MT for suggestions > Permission: Use machine translation services
  • Use TM for suggestions > Permission: Use translation memory

This all works out fine for any language showing the MT tab and the TM tab, to use results from MT and TM to do suggestions, but for the source language.

After some trial and error, I found out that I need to add another permission to allow the user to have MT and TM tab shown also for source strings:

  • Add edit source strings > Permission: Edit source strings

Once this permission is added, the MT and TM tabs are also available for suggestions on the source string.

To me this looks faulty, since for all derived translations it is NOT required to add the permission Edit strings. There the "use MT" and the "use TM" permissions is sufficient.

To Reproduce the bug

  1. create a role with the above permissions
  2. via group assignment, assign role to a test user
  3. log-in with this test user and try to suggest on source language based on MT and TM results
  4. MT and TM tab are not shown

Work around:

  1. add permission Edit source strings to role Basic Permissions
  2. Now this user can see the MT and TM tab and also use it for suggestions

Expected behavior

The Permissions:

  • Use MT for suggestions > Permission: Use machine translation services
  • Use TM for suggestions > Permission: Use translation memory

Should be sufficient to see MT and TM tab on source string

Server configuration and status

Still running 4.1.1-1 from hub.docker.com

@nijel nijel self-assigned this Nov 9, 2020
@nijel nijel added the bug Something is broken. label Nov 9, 2020
@nijel nijel added this to the 4.4 milestone Nov 9, 2020
@nijel nijel closed this as completed in 9f5d6bc Nov 9, 2020
@github-actions
Copy link

github-actions bot commented Nov 9, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants