Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ignore-same" not work #4941

Closed
ghost opened this issue Nov 30, 2020 · 5 comments
Closed

"ignore-same" not work #4941

ghost opened this issue Nov 30, 2020 · 5 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@ghost
Copy link

ghost commented Nov 30, 2020

weblate version: Weblate 4.3.2

I use api (PUT /api/units/(int:id)/) with "extra_flags":"ignore-same" to update enties. But weblate still mention "Unchanged translation".

@nijel
Copy link
Member

nijel commented Nov 30, 2020

Did the PUT succeed? Looking at the code it seems to correctly trigger checks update on flags change.

@nijel nijel added the question This is more a question for the support than an issue. label Nov 30, 2020
@github-actions
Copy link

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger. In case your question is already answered, making a donation is the right way to say thank you!

@ghost
Copy link
Author

ghost commented Nov 30, 2020

Yes, It returns 200 and target has been update.

@nijel
Copy link
Member

nijel commented Nov 30, 2020

The extra_flags can be changed only on source units, see https://docs.weblate.org/en/latest/api.html#patch--api-units-(int-id)-

It seems to be silently ignored when changing translation units though...

@nijel nijel added enhancement Adding or requesting a new feature. and removed question This is more a question for the support than an issue. labels Nov 30, 2020
@nijel nijel added this to To do in API improvements via automation Nov 30, 2020
@nijel nijel added this to the 4.4 milestone Nov 30, 2020
@nijel nijel self-assigned this Nov 30, 2020
@nijel nijel closed this as completed in 469acda Nov 30, 2020
API improvements automation moved this from To do to Done Nov 30, 2020
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
Status: Done
Development

No branches or pull requests

1 participant