Things to check panels not dismissable

[minusf]

Describe the bug

The "Things to check" panel shows notes like "Long untranslated", etc. The "Dismiss" and "Dismiss for all languages" buttons result in 405 Method not Allowed errors and can't be dismissed.

The issue seems to be that ignore_check is marked @require_POST: https://github.com/WeblateOrg/weblate/blob/master/weblate/trans/views/js.py#L116 while templates/translate.html has no POST forms for the check ignores.

This bug was noticed on an older installation of 4.1.1 but it seems to be the case for master still as well.

To Reproduce the bug

1. Try to dismiss a "Things to check" panel.

[nijel]

This is supposed to happen in JavaScript, the link has check-dismiss class and that is handled here:

weblate/weblate/static/editor/full.js

Lines 303 to 322 in aeede8d

	/* Check ignoring */
	this.$editor.on("click", ".check-dismiss", (e) => {
	var $el = $(e.currentTarget);
	$.ajax({
	type: "POST",
	url: $el.attr("href"),
	data: {
	csrfmiddlewaretoken: this.csrfToken,
	},
	error: function (jqXHR, textStatus, errorThrown) {
	addAlert(errorThrown);
	},
	});
	if ($el.hasClass("check-dismiss-all")) {
	$el.closest(".check").remove();
	} else {
	$el.closest(".check").toggleClass("check-dismissed");
	}
	return false;
	});

Do you have JavaScript enabled? Did you run collectstatic on upgrade?

[github-actions]

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger. In case your question is already answered, making a donation is the right way to say thank you!

[minusf]

yes, the file is present on the server under data/static/editor/full.js but it doesnt seem to be included in output.XXX.js by django compressor.

[minusf]

i turned of COMPRESS_ENABLED and the js files are still not loaded from translate.html template.

  <script defer data-cfasync="false" src="/static/js/slugify.js?v=4.1.1" type="text/javascript"></script>
  <script defer data-cfasync="false" src="/static/loader-bootstrap.js?v=4.1.1" type="text/javascript"></script>

---> this is where they should show up

  <link rel="image_src" type="image/png" href="/static/weblate-128.png"/>

very strange

[minusf]

i found the issue, it was an out of date locally modified base.html. I apologize for the noise and thanks for the clues.

[github-actions]

The issue you have reported is resolved now. If you don’t feel it’s right, please follow it’s labels to get a clue and take further steps.

• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.