Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker tag latest is missing #66

Closed
williamdes opened this issue Dec 19, 2020 · 7 comments
Closed

Docker tag latest is missing #66

williamdes opened this issue Dec 19, 2020 · 7 comments
Assignees
Labels
bug Something is broken.

Comments

@williamdes
Copy link

WeblateOrg/weblate@cd388b0

williamdes@williamdes:/mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO$ docker run --rm weblate/wlc
Unable to find image 'weblate/wlc:latest' locally
docker: Error response from daemon: manifest for weblate/wlc:latest not found: manifest unknown: manifest unknown.
See 'docker run --help'.
williamdes@williamdes:/mnt/Dev/@phpmyadmin/theREALphpMyAdminREPO$ docker pull weblate/wlc
Using default tag: latest
Error response from daemon: manifest for weblate/wlc:latest not found: manifest unknown: manifest unknown

Why: there is no latest tag on docker hub

Fix: replace weblate/wlc by weblate/wlc:edge in docs

Please also document how to bind a local config file .weblate using docker

docker run -v $(pwd):/home/weblate --rm weblate/wlc:edge show

Source for /home/weblate:

wlc/Dockerfile

Line 13 in e2139fb

WORKDIR /home/weblate

Feel free to add this example

$ docker run -v $(pwd):/home/weblate --rm weblate/wlc:edge show
branch: QA_5_1
file_format: po
filemask: po/*.po
git_export: https://hosted.weblate.org/git/phpmyadmin/5-1/
license: GPL-3.0-or-later
license_url: https://www.gnu.org/licenses/gpl-3.0-standalone.html
name: 5.1
new_base: po/phpmyadmin.pot
project: phpmyadmin
repo: https://github.com/phpmyadmin/phpmyadmin.git
slug: 5-1
source_language: en
template: 
url: https://hosted.weblate.org/api/components/phpmyadmin/5-1/
vcs: git
web_url: https://hosted.weblate.org/projects/phpmyadmin/5-1/
@nijel
Copy link
Member

nijel commented Dec 20, 2020

The latest tag will be there once there will be first stable release with Docker image, which didn't yet happen.

@nijel nijel transferred this issue from WeblateOrg/weblate Dec 20, 2020
@nijel nijel added the bug Something is broken. label Dec 20, 2020
@nijel nijel changed the title Docker documentation for wlc is wrong Docker tag lastest is missing Dec 20, 2020
@williamdes
Copy link
Author

The latest tag will be there once there will be first stable release with Docker image, which didn't yet happen.

Oh okay, I was a too quick tester ^^

@nijel
Copy link
Member

nijel commented Dec 20, 2020

I'd rather say we're super slow to release this...

@williamdes
Copy link
Author

I am happy to review any Docker PRs if you need, just ping me

@nijel
Copy link
Member

nijel commented Dec 20, 2020

I think that the only missing thing (besides the configuration docs you've reported) is tagging the release. I will probably do that tomorrow.

@nijel nijel self-assigned this Dec 21, 2020
@nijel nijel changed the title Docker tag lastest is missing Docker tag latest is missing Dec 21, 2020
@nijel
Copy link
Member

nijel commented Dec 21, 2020

I've tagged the release now and the image is published.

@nijel nijel closed this as completed Dec 21, 2020
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants