Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting i18n translations as iOS strings breaks strings format #5144

Closed
1 task done
agdt3 opened this issue Jan 5, 2021 · 2 comments
Closed
1 task done

Exporting i18n translations as iOS strings breaks strings format #5144

agdt3 opened this issue Jan 5, 2021 · 2 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@agdt3
Copy link

agdt3 commented Jan 5, 2021

Describe the issue

I've created a number of monolingual translations by importing a JSON i18next file. When I attempt to export/download the translations as iOS strings, I get the following format:
key=value
instead of
"key" = "value";

Example:
Initial JSON string:
"profile.edit.leave_modal.cancel": "Leave without saving",

Output iOS String:
profile.edit.leave_modal.cancel=Leave without saving

I already tried

Not sure how to debug this apart from reading the documentation.

Describe the steps you tried to solve the problem yourself.

  • I've read and searched the docs and did not find the answer there.
    If you didn’t try already, try to search there what you wrote above.

To Reproduce the issue

Steps to reproduce the behavior:

  1. Upload a JSON i18next translation file
  2. Download translations as Apple iOS Strings format

Edit: if this is a translation-tools issue, I can post this ticket over there instead.

Expected behavior

My expectation was that the correct iOS strings format was to be exported (unless I'm seriously misunderstanding something about the iOS strings format).

Server configuration and status

* Weblate: 4.4
 * Django: 3.1.4
 * siphashc: 2.1
 * Whoosh: 2.7.4
 * translate-toolkit: 3.2.0
 * lxml: 4.6.2
 * Pillow: 8.0.1
 * bleach: 3.2.1
 * python-dateutil: 2.8.1
 * social-auth-core: 3.3.3
 * social-auth-app-django: 4.0.0
 * django-crispy-forms: 1.10.0
 * oauthlib: 3.1.0
 * django-compressor: 2.4
 * djangorestframework: 3.12.2
 * django-filter: 2.4.0
 * django-appconf: 1.0.4
 * user-agents: 2.2.0
 * filelock: 3.0.12
 * setuptools: 40.8.0
 * jellyfish: 0.8.2
 * openpyxl: 3.0.5
 * celery: 5.0.4
 * kombu: 5.0.2
 * translation-finder: 2.6
 * weblate-language-data: 2020.13
 * html2text: 2020.1.16
 * pycairo: 1.16.2
 * pygobject: 3.30.4
 * diff-match-patch: 20200713
 * requests: 2.25.0
 * django-redis: 4.12.1
 * hiredis: 1.1.0
 * sentry_sdk: 0.19.5
 * Cython: 0.29.21
 * misaka: 2.1.1
 * GitPython: 3.1.11
 * borgbackup: 1.1.14
 * pyparsing: 2.4.7
 * Python: 3.7.3
 * Git: 2.20.1
 * psycopg2: 2.8.6
 * psycopg2-binary: 2.8.6
 * phply: 1.2.5
 * chardet: 3.0.4
 * ruamel.yaml: 0.16.12
 * tesserocr: 2.5.1
 * akismet: 1.1
 * boto3: 1.16.36
 * zeep: 4.0.0
 * aeidon: 1.7.0
 * iniparse: 0.5
 * mysqlclient: 2.0.2
 * Mercurial: 5.6.1
 * git-svn: 2.20.1
 * git-review: 1.28.0
 * Redis server: 6.0.9
 * PostgreSQL server: 13.1
 * Database backends: django.db.backends.postgresql
 * Cache backends: default:RedisCache, avatar:FileBasedCache
 * Email setup: django.core.mail.backends.smtp.EmailBackend: smtp.example.com
 * OS encoding: filesystem=utf-8, default=utf-8
 * Celery: redis://cache:6379/1, redis://cache:6379/1, regular
 * Platform: Linux 4.19.76-linuxkit (x86_64)
@nijel nijel added the bug Something is broken. label Jan 6, 2021
@nijel nijel self-assigned this Jan 6, 2021
@nijel nijel added this to the 4.4.1 milestone Jan 6, 2021
@nijel nijel closed this as completed in 6741624 Jan 6, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@agdt3
Copy link
Author

agdt3 commented Jan 7, 2021

@nijel thank you for the quick response/fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants