Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not "unlock "notification #5226

Closed
ldmpub opened this issue Jan 18, 2021 · 3 comments
Closed

Not "unlock "notification #5226

ldmpub opened this issue Jan 18, 2021 · 3 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@ldmpub
Copy link
Contributor

ldmpub commented Jan 18, 2021

Describe the issue

  1. I receive a notification "New strings to translate" after a translation update

  2. I click on the link and the translation is in "Lock" state
    => everything is OK

  3. I click on the option "Warn me when translation will be unlocked" => see screen shot (in french) ; I get Weblate info "notification updated"

  4. I never receive any mail, like if the translation is never unlocked which is wrong...
    Notification when Unlocked

To Reproduce the issue

See https://hosted.weblate.org/translate/osmand/main/fr/?q=is:untranslated ; try to activate the "unlock notification" ... you may not receive any mail.

Expected behavior

Be warned when translation is unlocked.

Screenshots
See above.

Server configuration
Hosted Weblate

Additional context
This "unlock" notification feature had never worked for me.

@nijel nijel added the bug Something is broken. label Jan 18, 2021
@nijel nijel self-assigned this Jan 18, 2021
@nijel nijel added this to the 4.5 milestone Jan 18, 2021
@nijel nijel closed this as completed in 31709b0 Jan 18, 2021
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 29, 2021

Hi,

First "unlock notification" received => I confirm this issue is closed. Thanks 👍

I wonder if you consider as normal the fact that if you go back top page while Component is locked and you already have request to be automaticaly warned when unlock => the button "Notify me when unlock" is always displayed / available? May I fill a bug or an improvment or nothing for this particular "case"? (I already "pushed the button" but button is still displayed).

@nijel
Copy link
Member

nijel commented Jan 29, 2021

Yes, the button is always displayed to make the code simpler. Feel free to open a separate issue for that, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants