Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect locale code for simplified chinese in App Store Metadata files #5446

Closed
ashutoshgngwr opened this issue Feb 15, 2021 · 1 comment
Closed
Assignees
Labels
bug Something is broken.
Milestone

Comments

@ashutoshgngwr
Copy link

Describe the issue

Weblate outputs incorrect language code for Android App Store Metadata files. Google Play Store supports 'zh-CN' for simplified Chinese whereas Weblate outputs 'zh_Hans'. This will cause fatal errors when pushing changes using Fastlane.

I have an open PR from Weblate that highlights the issue in this file. The issue possibly extends to other languages as well.

Additionally, the following screenshot shows the chinese locale codes accepted by the Play Store.

image

Related Issues

  1. Are google language codes compatible with Weblate? #4078
  2. Android: Generates invalid directory for Simplified Chinese (and possibly other languages) #1415

To Reproduce the issue

  1. Add simplified Chinese translations for App Store metadata (Fastlane supply in my case)
  2. Commit changes
  3. Error

Expected behavior

The output code should 'zh-CN' instead of 'zh_Hans'.

@nijel nijel self-assigned this Feb 15, 2021
@nijel nijel added the bug Something is broken. label Feb 15, 2021
@nijel nijel added this to the 4.5 milestone Feb 15, 2021
@nijel nijel closed this as completed in 64c1c0d Feb 15, 2021
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants