Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary components - Create New Translations settings are always enabled, even if disabled for "oringial" component #5496

Closed
ilocit opened this issue Feb 22, 2021 · 3 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@ilocit
Copy link
Contributor

ilocit commented Feb 22, 2021

After migrating to v4.5 for each project/component a new Glossary component is/was created.
This component did not inherit the "Adding new translation" setting from the project/component, but was set to "Create new language file". So now the translators can create new translations for those. This is not the desired behavior.

  • By default it should be disabled or inherit the setting from the main component/project.

CURRENT:
image

Expected:
image

Question:
Can this be fixed generally, or do we now need to change this for each of the dozens new Glossary components which were created during the migration to v4.5?

@comradekingu
Copy link
Contributor

comradekingu commented Feb 24, 2021

@ilocit You are killing me here. "oringial" should be "original".


I think it may depend on whether the components themselves are set as slaves to a master component https://docs.weblate.org/no/weblate-4.5/admin/projects.html#component-repo

Says it is the default behavior to create new glossaries for everything https://docs.weblate.org/no/weblate-4.5/user/glossary.html#managing-glossaries

If translators aren't allowed to create translations of the glossary, you lose out on sidebar suggestions. Why is it not desired?

Where do you get "Adding new translation" from btw?

@nijel
Copy link
Member

nijel commented Mar 1, 2021

Adding is turned on by default for glossaries, but it should not be needed since 1651270, so it seems better to turn it off by default.

@nijel nijel self-assigned this Mar 1, 2021
@nijel nijel added the enhancement Adding or requesting a new feature. label Mar 1, 2021
@nijel nijel added this to the 4.5.1 milestone Mar 1, 2021
@nijel nijel closed this as completed in 63b750d Mar 5, 2021
@github-actions
Copy link

github-actions bot commented Mar 5, 2021

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants