Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different spellcheck dictionaries for target and comment text boxes #5676

Closed
rffontenelle opened this issue Mar 16, 2021 · 7 comments
Closed
Labels
enhancement Adding or requesting a new feature. help wanted Extra attention is needed. undecided These features might not be implemented. Can be prioritized by sponsorship. ux Issues related to user experience. wontfix Nobody will work on this.

Comments

@rffontenelle
Copy link
Contributor

Is your feature request related to a problem? If so, please describe.

Firefox allows more than language to be spell-checked with its spellcheck dictionaries (going to use "dict" from now on), but uses the only one selected (not all together) per "context". By "context" (which I'm not sure what is, technically speaking) I mean that I can have English set for Weblate and another language for another website (say, writing in issues text boxes in GitHub); but can't have both languages set simultaneously for Weblate.

When translating in Weblate (in Firefox), I rather use my language dict in the translation ("target") text box, and English dict when writing a comment for the source string.

Currently, the dict used in one box applies to the other. So, I have to switch dict if I want the spellcheck to work properly when e.g. I want to write a comment in Weblate.

Describe the solution you'd like

I would like to be able to set a spellcheck dictionary to each of the aforementioned boxes (translation box and comment box), without needing to switch everytime I want to use the spellchecking in them.

Describe alternatives you've considered

No alternatives comes to my mind at the moment.

Screenshots

Here is a screenshot of the Weblate translation editor, showing the translation box with a text in Brazilian Portuguese, flagged as misspelled by Firefox spellcheck feature with English dictionary set, and the commentary box with text in English, not misspelling flag applied:

spellcheck-dict

Additional context

@nijel
Copy link
Member

nijel commented Mar 16, 2021

I have no clue how to achieve this. The translation textarea has correctly set language, but that seems to do nothing for Firefox spellchecker.

@nijel nijel added enhancement Adding or requesting a new feature. help wanted Extra attention is needed. undecided These features might not be implemented. Can be prioritized by sponsorship. ux Issues related to user experience. labels Mar 16, 2021
@github-actions
Copy link

This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate. Please try to clarify the use case or consider proposing something more generic to make it useful to more users.

@rffontenelle
Copy link
Contributor Author

rffontenelle commented Mar 16, 2021

@nijel Can you please point me to the file for the textarea with language set?

@nijel
Copy link
Member

nijel commented Mar 16, 2021

It's lang attribute on the textarea:

attrs["lang"] = lang.code

@rffontenelle
Copy link
Contributor Author

Thanks. Searching for info on firefox+textarea+lang, I found this meta-bag entitled "[meta] Spellchecker fails to honour/remember user's choice of language/dictionary", with some explanation on how Firefox works with lang selecting and some dependency bugs not yet closed: https://bugzilla.mozilla.org/show_bug.cgi?id=1073827#c33

Hope it helps

@nijel
Copy link
Member

nijel commented Mar 17, 2021

It all seems to relate to site only, not to individual inputs...

@nijel nijel added the wontfix Nobody will work on this. label Apr 16, 2021
@nijel
Copy link
Member

nijel commented Apr 16, 2021

I don't see anything we could do here - the lang attribute on the textarea is set, and it's up to the browser if it will use it or not.

@nijel nijel closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. help wanted Extra attention is needed. undecided These features might not be implemented. Can be prioritized by sponsorship. ux Issues related to user experience. wontfix Nobody will work on this.
Projects
None yet
Development

No branches or pull requests

2 participants