Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab fork merge requests pending due to missing pipelines #5718

Closed
1 task done
remcohaszing opened this issue Mar 22, 2021 · 11 comments
Closed
1 task done

GitLab fork merge requests pending due to missing pipelines #5718

remcohaszing opened this issue Mar 22, 2021 · 11 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@remcohaszing
Copy link

Describe the issue

We have configured Weblate to create merge requests from a fork. For example, see appsemble/appsemble!1715. However, the merge requests can’t be merged because the merge request shows a spinner indefinitely. I think gitlab-org/gitlab#300471 is related.

I see 2 possible solutions:

  1. Enable pipelines publicly for the fork.
  2. Give owners of the original project access to the Weblate fork. This also allows maintainers to further tweak the fork, i.e. change the description / tags / logo. This also allows them to enable pipelines publicly if they desire.

I already tried

I tried creating a new account on GitLab, forking the project from that account, and creating a merge request. If I change the merge request visibility to Everyone With Access in the project settings of the fork, I notice the same behaviour as for Weblate merge requests when looking at the merge request as owner of the original project.

  • I've read and searched the docs and did not find the answer there.
    If you didn’t try already, try to search there what you wrote above.

To Reproduce the issue

See I already tried

Expected behavior

Weblate forks have pipelines enabled in a way project maintainers of the original project can see it.

Screenshots

image

Exception traceback

N/A

Server configuration and status

Weblate installation: weblate.org

Weblate deploy checks

N/A

@nijel
Copy link
Member

nijel commented Mar 22, 2021

Do you know which flag needs to be toggled to do this? Is it "builds_access_level"? See https://docs.gitlab.com/ee/api/projects.html#edit-project

@nijel nijel added the enhancement Adding or requesting a new feature. label Mar 22, 2021
@nijel
Copy link
Member

nijel commented Mar 22, 2021

Also, you can let Weblate push to a different branch in your repository to avoid such problems, see https://docs.weblate.org/en/latest/admin/continuous.html#push-changes

@remcohaszing
Copy link
Author

Yes, toggling Pipelines in the project settings seems to change the builds_access_level when I inspect the PUT request made on gitlab.com.

Having Weblate push to a different branch on the main repository has other quirks. I.e. ideally the Weblate branch should be protected from other project members, but then Weblate can’t rebase and force push.

@nijel nijel self-assigned this Mar 22, 2021
@nijel nijel added this to the 4.5.2 milestone Mar 22, 2021
@nijel nijel closed this as completed in da4247d Mar 22, 2021
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@remcohaszing
Copy link
Author

That was super fast!

Is there any ETA when this will be available on https://hosted.weblate.org?

@nijel
Copy link
Member

nijel commented Mar 24, 2021

It should be already there. I'm just not sure if it will update existing forks, feedback on that is welcome.

@remcohaszing
Copy link
Author

I think existing forks need to be updated. Anyone should be able to access https://gitlab.com/weblate/appsemble/-/pipelines (or the same page for different projects forked by weblate).

@nijel
Copy link
Member

nijel commented Mar 24, 2021

I think it should be update on creating a new pull request.

@remcohaszing
Copy link
Author

I just tried that, but it didn’t work.

@nijel
Copy link
Member

nijel commented Mar 24, 2021

Ah okay, it does it only when the remote is not yet configured in Weblate... I've changed the repo configuration manually now.

@remcohaszing
Copy link
Author

Since no pipeline was created yet, I had to close the open merge request and push from the Weblate interface. This created a pipeline for the new merge request (appsemble/appsemble!1731), which can now me merged.

Thanks for your help and fast replies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants