Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue reported when creating component via "Translate Document" #6104

Closed
ilocit opened this issue May 28, 2021 · 4 comments
Closed

Issue reported when creating component via "Translate Document" #6104

ilocit opened this issue May 28, 2021 · 4 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@ilocit
Copy link
Contributor

ilocit commented May 28, 2021

When adding a new component to a project via Translate Document, a config error is shown which is not relevant.

Repo Steps:

  1. In a project create a new component via Translate Document
  2. Select the file you want to translate (e.g. demo-translation-file.odt)
  3. Select the proposed Open Doc Format and confirm the default settings proposed by Weblate (the only change to the default I make/made is to disable Edit base file)
  4. After the component is created, the following message is displayed.
    image

Contrary to the message, the component is fully functional and target languages can be added.
The error does not seem to be an error and should be handled differently, ie. not shown in the UI.

@ilocit
Copy link
Contributor Author

ilocit commented May 28, 2021

To give this some context:
I understand where this comes from, the new component obviously does not have any translations yet, because only one (source) document was uploaded. As a techie, this error might not be important and is ignored. But we are using Weblate also as a kind of "self-service" portal for our customers. And they reported this as an issue repeatedly and we have to deal with it ;-)
So it would be nice if this could be captured as a none-relevant error in case a single document is uploaded as a new translation component.

@nijel
Copy link
Member

nijel commented Jun 1, 2021

The question is what is the correct solution here - there are no translations, so it's pointless to have this in Weblate without them.

  • Should the wording be changed to guide the user more towards creating a translation instead?
  • Should this be disabled for document like formats?
  • Should the "Translate document" feature force user to select at least one language and create the translation while importing?

@ilocit
Copy link
Contributor Author

ilocit commented Jun 1, 2021

I'd say whatever is the easiest to implement.
Maybe the wording is the easiest to adjust? So more like an info than a warning/issue?
Adding that if a monolingual document was uploaded, it is necessary to create at least one language in the Component UI.
If it is easy enough to "catch" this issue message in case of manually uploaded, monolingual documents, then it would be best just to suppress the message.

@nijel nijel self-assigned this Jun 1, 2021
@nijel nijel added the enhancement Adding or requesting a new feature. label Jun 1, 2021
@nijel nijel added this to the 4.7 milestone Jun 1, 2021
@nijel nijel closed this as completed in b8834e6 Jun 1, 2021
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants