-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If you change the "Full name", it will look like another contributor. #6116
Comments
The issue you've reported needs to be addressed in the translate-toolkit. Please file the issue there, and include links to any relevant specifications about the formats (if applicable). |
Right now, name and e-mail have to match to extend existing entries: It could probably do something more clever in case only name changes, but I'm not confident if that is desired in all cases. |
This has implications for trans people: Weblate shouldn’t dead-name them after they transition. |
Weblate uses whatever name user configures. The past Git commits will contain previous name and rewriting history is not an option. For changing the name in the file credits, Weblate would have to look into all translations the user has contributed to and change the name and e-mail accordingly. It's doable, but it could be a dangerous operation. It would be fragile and expensive operation, and it could lead to DoS. So I don't think Weblate should be changing past entries. |
It turns out that this can cause some very difficult problems. |
Thank you for your report; the issue you have reported has just been fixed.
|
Describe the issue
If you change a "Full name" on account/profile, it will look like another contributor in a PO file.
To Reproduce the issue
Steps to reproduce the behavior:
e.g. https://hosted.weblate.org/projects/weblate/languages/ja/
Files -> Download tranlation
weblate-languages-ja.po
| # baffclan <baffclan_at_yahoo.co.jp>, 2020.
| # 日陰のコスモス <baffclan_at_yahoo.co.jp>, 2020, 2021.
Expected behavior
Update to new Full name + email address
| # 日陰のコスモス <baffclan_at_yahoo.co.jp>, 2020, 2021.
The following is unnecessary:
| # baffclan <baffclan_at_yahoo.co.jp>, 2020.
The text was updated successfully, but these errors were encountered: