Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you change the "Full name", it will look like another contributor. #6116

Closed
baffclan opened this issue May 31, 2021 · 6 comments
Closed
Labels
enhancement Adding or requesting a new feature. translate-toolkit Issues which need to be fixed in the translate-toolkit

Comments

@baffclan
Copy link
Contributor

Describe the issue
If you change a "Full name" on account/profile, it will look like another contributor in a PO file.

To Reproduce the issue

Steps to reproduce the behavior:

  1. Download a tranlation file
    e.g. https://hosted.weblate.org/projects/weblate/languages/ja/
    Files -> Download tranlation
  2. Open a tranlation file
    weblate-languages-ja.po
    | # baffclan <baffclan_at_yahoo.co.jp>, 2020.
    | # 日陰のコスモス <baffclan_at_yahoo.co.jp>, 2020, 2021.

Expected behavior

Update to new Full name + email address
| # 日陰のコスモス <baffclan_at_yahoo.co.jp>, 2020, 2021.

The following is unnecessary:
| # baffclan <baffclan_at_yahoo.co.jp>, 2020.

@nijel nijel added enhancement Adding or requesting a new feature. translate-toolkit Issues which need to be fixed in the translate-toolkit labels May 31, 2021
@github-actions
Copy link

The issue you've reported needs to be addressed in the translate-toolkit. Please file the issue there, and include links to any relevant specifications about the formats (if applicable).

@nijel
Copy link
Member

nijel commented May 31, 2021

Right now, name and e-mail have to match to extend existing entries:

https://github.com/translate/translate/blob/5714d6fe0794cbfdbc9d7da216028d9bbf79228e/translate/storage/poheader.py#L397-L451

It could probably do something more clever in case only name changes, but I'm not confident if that is desired in all cases.

@fitojb
Copy link
Contributor

fitojb commented Jun 5, 2021

This has implications for trans people: Weblate shouldn’t dead-name them after they transition.

@nijel
Copy link
Member

nijel commented Jun 8, 2021

Weblate uses whatever name user configures. The past Git commits will contain previous name and rewriting history is not an option.

For changing the name in the file credits, Weblate would have to look into all translations the user has contributed to and change the name and e-mail accordingly. It's doable, but it could be a dangerous operation. It would be fragile and expensive operation, and it could lead to DoS. So I don't think Weblate should be changing past entries.

@baffclan
Copy link
Contributor Author

baffclan commented Jun 8, 2021

It turns out that this can cause some very difficult problems.
I am withdrawing this issue.

@baffclan baffclan closed this as completed Jun 8, 2021
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. translate-toolkit Issues which need to be fixed in the translate-toolkit
Projects
None yet
Development

No branches or pull requests

3 participants