Link between glossary term and source key gets lost

[ghost]

Describe the issue

When adding a new term to the glossary using the 'Add term to glossary' function in the translation section, the added term does not remain linked to the source key it was added to.

I already tried

Different types of glossary configurations, respectively the file type configuration were tried.

To Reproduce the issue

Steps to reproduce the behavior:

1. Open an existing translation component in the project containing some translation strings
2. Start the translation and click on 'Add term to glossary' on any item.
3. Fill in the form fields and add the new term. The glossary component shows the new term now
   
4. Now forward to the next translation item and go back again.

Expected behavior

The glossary component shows the term as described in Step 3

Actual behavior

No term is shown, however the glossary contains the new term. Furthermore the fields do not match together and seem to be inconsistent as can be seen in the screenshot:

[ghost]

I just realized, the the form for adding a term directly in the glossary component also looks entirely different compared to the ones shown under 'Actual behavior':

[comradekingu]

Why is it
"clarify source strings" (plural) and not "clarify the meaning"?

Other suggestions:
"Auto-adjust context when an identical string exists" (What happens?)
"The string will propagate to the glossary in all languages"

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

[JohnRDOrazio]

I have noticed that even with Weblate 4.7.2, when using "Add term to glossary" from the sidebar of a translation component, the term and it's translation are added to the glossary with an empty key. Then when I try to "Add term to glossary" again, it fails, because it is trying to create a new term with, again, an empty key, however an empty key already exists in the glossary. So there is a conflict of "two identical keys" (which are both empty).

Is this the issue that was fixed? Or should I open a new issue?

[nijel]

@JohnRDOrazio This should be fixed in 4.8 (and one more fix for glossary adding is in place for 4.8.1.).

[ghost]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

I just tried it with v4.8.1 - the problem still exists.

[JohnRDOrazio]

I just tried in v4.8.1, and I see that the first term added using the sidebar of a translation component seems to have an empty key, whereas the next terms added have numbered keys starting from 1. I am not getting an error when adding new glossary terms from the sidebar of a translation component.

[nijel]

Yes, the source / key combination has to be unique, so if the source already exists, unique key is automatically generated. But we're getting off-topic here...

[ghost]

Ok, so what does that mean? Do you still consider this as closed? Because for me this issue still exists the way it initially was described.

[nijel]

The glossary sidebar shows matching terms. If the term is not present in the translated string, it won't be shown. There is no other linking of glossary terms to strings.