Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculations of fields #6198

Closed
milotype opened this issue Jun 17, 2021 · 10 comments
Closed

Calculations of fields #6198

milotype opened this issue Jun 17, 2021 · 10 comments

Comments

@milotype
Copy link
Contributor

Describe the issue

  1. Some fields do not show any content/value
  2. Number of contributors is zero!
  3. Calculations mismatch

To Reproduce the issue

Go to 'https://hosted.weblate.org/projects/openbikesharing/#information' (maybe this issue applies to other projects as well)

Expected behavior

  1. Fields should not be emty
  2. Number of contributors should be calculated. If 92% is transalated, it is impossible that there is no contributor involved. Even if the project has only the source strings (mostly in english), the minimum for this field should be at least 1.
  3. If there is a percentage for "Trends ...", there should be a number/value in the above field as well.

Screenshots

Calculations

@comradekingu
Copy link
Contributor

Can confirm, the strings translated was too high in Remmina.

@milotype Could it be that 92% got imported and wasn't translated in Weblate?
Or 92% is read-only strings?

"Hosted strings" and "Hosted words" for last 30 days should be populated?
Or is it only new ones?

@nijel
Copy link
Member

nijel commented Jun 18, 2021

  1. Why show 100% there? Showing it adds no value.
  2. It's contributors in last 30 days.
  3. A dash is shown when there is no change in the value for 30 days.

@comradekingu
Copy link
Contributor

"30 day trend" or "last 30 days" makes more sense to me.
Isn't the top field for "translated" in the last 30 supposed to have something?

@nijel
Copy link
Member

nijel commented Jun 18, 2021

Isn't the top field for "translated" in the last 30 supposed to have something?

It behaves as expected now - there was no change in last 30 days in this. Maybe dash is not the best indication of this, though...

@milotype
Copy link
Contributor Author

1. Why show 100% there? Showing it adds no value.

True, but a field should IMO allways have a value ... otherwise it looks like a mistake/error to me ...

@nijel
Copy link
Member

nijel commented Jun 21, 2021

Any listing in Weblate also shows blank space instead of showing zeroes:

image

@comradekingu
Copy link
Contributor

comradekingu commented Jun 21, 2021

I was thinking "changes" instead of "trends" with something like
bilde
or the up and down symbols with that flat thing in the middle?

bilde

bilde

Possibly washed out top and down colours.

If everything but the trending direction was grayed out, and everything was in black and white there wouldn't be a red/green colourblind problem to begin with.

bilde

In norway the -||- symbol is used for same, but that is usually repetition of an already mentioned item in a list.

Edit: I don't know what the bottom row of percentages signifies.
Ah, that is the previous numbers.

@milotype
Copy link
Contributor Author

Any listing in Weblate also shows blank space instead of showing zeroes:

image

But why do you want to have, or what is the use of empty fields?? Think about blind persons ... empty fields have no content!

@nijel
Copy link
Member

nijel commented Jun 22, 2021

Because it attracts attention to the non-empty fields, which are more important. To address accessibility, sr-only content could be added, but that's yet another topic mixed into this issue.

@milotype
Copy link
Contributor Author

Yes, I aggree about your explanation about attracting attention ... Good point!

I'm sorry I can't really help with implementing sr-only content ... I'm no UI expert, so just as a suggestion:

  • if a field is empty, screenreaders should read something like "This field is empty" or "100%" or "Zero" (depending upon the contents)
  • if a field consists of a dash character, screenreaders should read something like "None" or "Zero".

@nijel nijel closed this as completed Jun 24, 2021
@WeblateOrg WeblateOrg locked and limited conversation to collaborators Jun 24, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants