Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismissing a check sometimes leads to empty page #6398

Closed
1 task done
gunchleoc opened this issue Aug 8, 2021 · 2 comments
Closed
1 task done

Dismissing a check sometimes leads to empty page #6398

gunchleoc opened this issue Aug 8, 2021 · 2 comments
Labels
wontfix Nobody will work on this.

Comments

@gunchleoc
Copy link

Describe the issue

While dismissing a check, I sometimes end up on a blank page. I suspect that this happens when I am clicking too fast while the page is still loading (I was doing lots of similar dismissals, so I was very fast clicking).

Workaround is to hit the browser's "Back" button and hit "Dismiss" again.

I already tried

Describe the steps you tried to solve the problem yourself.

  • I've read and searched the docs and did not find the answer there.

To Reproduce the issue

Steps to reproduce the behavior:

  1. Create a condition that will generate lots of failed checks, e.g. upload an untranslated file
  2. Start going through the failed strings
  3. Hit "Dismiss" and then "Skip" repeatedly
  4. Eventually, you'll end up on an empty page when clicking on "Dismiss" (see screenshot below)

Logs:
weblate-backup.log
weblate-backup-1.log
weblate-celery.log
weblate-celery-7.log
weblate-memory.log
weblate-notify.log
weblate-translate.log

Expected behavior

"Things to check" section updates with the dismissed check state

Screenshots
weblate-dismissed-check

Exception traceback

Server configuration and status

Weblate installation: PyPI

$ weblate list_versions

  • Weblate: 4.7.2
  • Django: 3.2.5
  • siphashc: 2.1
  • translate-toolkit: 3.3.6
  • lxml: 4.6.3
  • Pillow: 8.3.1
  • bleach: 3.3.1
  • python-dateutil: 2.8.2
  • social-auth-core: 4.1.0
  • social-auth-app-django: 4.0.0
  • django-crispy-forms: 1.12.0
  • oauthlib: 3.1.1
  • django-compressor: 2.4.1
  • djangorestframework: 3.12.4
  • django-filter: 2.4.0
  • django-appconf: 1.0.4
  • user-agents: 2.2.0
  • filelock: 3.0.12
  • setuptools: 44.0.0
  • jellyfish: 0.8.2
  • openpyxl: 3.0.7
  • celery: 5.1.2
  • kombu: 5.1.0
  • translation-finder: 2.9
  • weblate-language-data: 2021.5
  • html2text: 2020.1.16
  • pycairo: 1.20.1
  • pygobject: 3.40.1
  • diff-match-patch: 20200713
  • requests: 2.26.0
  • django-redis: 5.0.0
  • hiredis: 2.0.0
  • sentry_sdk: 1.3.1
  • Cython: 0.29.24
  • misaka: 2.1.1
  • GitPython: 3.1.18
  • borgbackup: 1.1.17
  • pyparsing: 2.4.7
  • pyahocorasick: 1.4.2
  • python-redis-lock: 3.7.0
  • Python: 3.8.10
  • Git: 2.25.1
  • psycopg2-binary: 2.9.1
  • phply: 1.2.5
  • chardet: 4.0.0
  • ruamel.yaml: 0.17.10
  • boto3: 1.18.7
  • zeep: 4.0.0
  • aeidon: 1.9
  • iniparse: 0.5
  • Mercurial: 5.3.1
  • Redis server: 5.0.7
  • PostgreSQL server: 12.7
  • Database backends: django.db.backends.postgresql
  • Cache backends: default:RedisCache, avatar:FileBasedCache
  • Email setup: django.core.mail.backends.smtp.EmailBackend: localhost
  • OS encoding: filesystem=utf-8, default=utf-8
  • Celery: redis://localhost:6379, redis://localhost:6379, regular
  • Platform: Linux 5.4.0-80-generic (x86_64)

Weblate deploy checks

$ weblate check --deploy

SystemCheckError: System check identified some issues:

ERRORS:
?: (weblate.E011) E-mail addresses for site admins is misconfigured
	HINT: https://docs.weblate.org/en/weblate-4.7.2/admin/install.html#production-admins

WARNINGS:
?: (security.W004) You have not set a value for the SECURE_HSTS_SECONDS setting. If your entire site is served only over SSL, you may want to consider setting a value and enabling HTTP Strict Transport Security. Be sure to read the documentation first; enabling HSTS carelessly can cause serious, irreversible problems.
?: (security.W008) Your SECURE_SSL_REDIRECT setting is not set to True. Unless your site should be available over both SSL and non-SSL connections, you may want to either set this setting True or configure a load balancer or reverse-proxy server to redirect all connections to HTTPS.
?: (security.W012) SESSION_COOKIE_SECURE is not set to True. Using a secure-only session cookie makes it more difficult for network traffic sniffers to hijack user sessions.
?: (security.W018) You should not have DEBUG set to True in deployment.
?: (weblate.W033.Gerrit) Failure in loading VCS module for Gerrit: git: 'review' is not a git command. See 'git --help'.
 (1)
	HINT: https://docs.weblate.org/en/weblate-4.7.2/vcs.html
?: (weblate.W033.Subversion) Failure in loading VCS module for Subversion: git: 'svn' is not a git command. See 'git --help'.

The most similar commands are
	fsck
	mv
	show
 (1)
	HINT: https://docs.weblate.org/en/weblate-4.7.2/vcs.html

INFOS:
?: (weblate.I021) Error collection is not set up, it is highly recommended for production use
	HINT: https://docs.weblate.org/en/weblate-4.7.2/admin/install.html#collecting-errors
?: (weblate.I028) Backups are not configured, it is highly recommended for production use
	HINT: https://docs.weblate.org/en/weblate-4.7.2/admin/backup.html

System check identified 9 issues (1 silenced).

@nijel
Copy link
Member

nijel commented Aug 9, 2021

HTTP 405 you can see in the log indicates bad method - the browser used GET instead of POST. Most likely because javascript was not yet loaded...

@github-actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Nobody will work on this.
Projects
None yet
Development

No branches or pull requests

2 participants