Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary terms might break placeholders #6506

Closed
1 task done
sgiehl opened this issue Sep 2, 2021 · 2 comments
Closed
1 task done

Glossary terms might break placeholders #6506

sgiehl opened this issue Sep 2, 2021 · 2 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@sgiehl
Copy link

sgiehl commented Sep 2, 2021

Describe the issue

We are using php format placeholders (%1$s, %d, ...) in our project. In some special cases (e.g. when replacing them with html tags) there is no space to the following word. We have found a special case, where it's followed by the word How.
As we have the word show defined in our glossary, weblate somehow mixes up the placeholder and glossary term:
image
Clicking on it inserts %3$sHow into the translation

I already tried

  • I've read and searched the docs and did not find the answer there.
    If you didn’t try already, try to search there what you wrote above.

To Reproduce the issue

Steps to reproduce the behavior:

  1. Go to https://hosted.weblate.org/translate/matomo/matomo-base/de/?checksum=a33df97c514f0924

Expected behavior

Weblate should not detect a glossary term in this case, as the s is part of a placeholder and not the following word.

Server configuration and status

Hosted Weblate

@nijel nijel self-assigned this Sep 7, 2021
@nijel nijel added the bug Something is broken. label Sep 7, 2021
@nijel nijel added this to the 4.8.1 milestone Sep 7, 2021
@nijel nijel closed this as completed in 5c47268 Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@sgiehl
Copy link
Author

sgiehl commented Sep 7, 2021

Thanks for working on that so quickly 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants