Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepL formality does not work as expected #6566

Closed
2 tasks done
matzeeable opened this issue Sep 20, 2021 · 3 comments
Closed
2 tasks done

DeepL formality does not work as expected #6566

matzeeable opened this issue Sep 20, 2021 · 3 comments
Assignees
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Milestone

Comments

@matzeeable
Copy link

Describe the issue

I have created a language "German (informal)" within my component, but the automatic DeepL suggestions still uses formal sentences.

I already tried

Describe the steps you tried to solve the problem yourself.

  • I've read and searched the docs and did not find the answer there.
  • Searched for issues within GitHub repository and did not find a similar ticket

To Reproduce the issue

  1. Create an English string Are you sure?
  2. Go to "German (informal)" language
  3. Open the automatic translation and DeepL still suggests Sind Sie sicher? instead of Bist du sicher?

Expected behavior

DeepL's suggestion should be Bist du sicher?.

I also checked out the API of DeepL, and they provide a field for formality: https://www.deepl.com/docs-api/translating-text/response/

Sets whether the translated text should lean towards formal or informal language. This feature currently only works for target languages "DE" (German), "FR" (French), "IT" (Italian), "ES" (Spanish), "NL" (Dutch), "PL" (Polish), "PT-PT", "PT-BR" (Portuguese) and "RU" (Russian).Possible options are:

  • "default" (default)
  • "more" - for a more formal language
  • "less" - for a more informal language

image

Server configuration and status

Docker, Weblate version 4.8.

 * Weblate: 4.8
 * Django: 3.2.6
 * siphashc: 2.1
 * translate-toolkit: 3.4.0
 * lxml: 4.6.3
 * Pillow: 8.3.1
 * bleach: 4.0.0
 * python-dateutil: 2.8.2
 * social-auth-core: 4.1.0
 * social-auth-app-django: 5.0.0
 * django-crispy-forms: 1.12.0
 * oauthlib: 3.1.1
 * django-compressor: 2.4.1
 * djangorestframework: 3.12.4
 * django-filter: 2.4.0
 * django-appconf: 1.0.4
 * user-agents: 2.2.0
 * filelock: 3.0.12
 * setuptools: 40.8.0
 * jellyfish: 0.8.2
 * openpyxl: 3.0.7
 * celery: 5.1.2
 * kombu: 5.1.0
 * translation-finder: 2.10
 * weblate-language-data: 2021.5
 * html2text: 2020.1.16
 * pycairo: 1.16.2
 * pygobject: 3.30.4
 * diff-match-patch: 20200713
 * requests: 2.26.0
 * django-redis: 5.0.0
 * hiredis: 2.0.0
 * sentry_sdk: 1.3.1
 * Cython: 0.29.24
 * misaka: 2.1.1
 * GitPython: 3.1.18
 * borgbackup: 1.1.17
 * pyparsing: 2.4.7
 * pyahocorasick: 1.4.2
 * python-redis-lock: 3.7.0
 * Python: 3.7.3
 * Git: 2.20.1
 * psycopg2: 2.9.1
 * psycopg2-binary: 2.9.1
 * phply: 1.2.5
 * chardet: 4.0.0
 * ruamel.yaml: 0.17.11
 * tesserocr: 2.5.2
 * akismet: 1.1
 * boto3: 1.18.26
 * zeep: 4.1.0
 * aeidon: 1.9
 * iniparse: 0.5
 * mysqlclient: 2.0.3
 * Mercurial: 5.9
 * git-svn: 2.20.1
 * git-review: 2.1.0
 * Redis server: 6.2.5
 * PostgreSQL server: 13.3
 * Database backends: django.db.backends.postgresql
 * Cache backends: default:RedisCache, avatar:FileBasedCache
 * Email setup: django.core.mail.backends.smtp.EmailBackend: smtp.mailersend.net
 * OS encoding: filesystem=utf-8, default=utf-8
 * Celery: redis://:WjUonTNhHsgHzp8iM66ofyALIz3u@weblate_redis:6379/1, redis://:WjUonTNhHsgHzp8iM66ofyALIz3u@weblate_redis:6379/1, regular
 * Platform: Linux 5.10.28-scaleway (x86_64)

Weblate deploy checks

System check identified some issues:

WARNINGS:
?: (security.W018) You should not have DEBUG set to True in deployment.

INFOS:
?: (weblate.I021) Error collection is not set up, it is highly recommended for production use
        HINT: https://docs.weblate.org/en/weblate-4.8/admin/install.html#collecting-errors
?: (weblate.I031) New Weblate version is available, please upgrade to 4.8.1.
        HINT: https://docs.weblate.org/en/weblate-4.8/admin/upgrade.html

System check identified 3 issues (1 silenced).

Additional context

Nothing.

@nijel
Copy link
Member

nijel commented Sep 20, 2021

The formality feature of DeepL is currently not utilized by Weblate, so both languages map to default German.

@nijel nijel added enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed. labels Sep 20, 2021
@github-actions
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@nijel nijel added the hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. label Oct 4, 2021
@nijel nijel self-assigned this Nov 23, 2021
@nijel nijel added this to the 4.10 milestone Nov 23, 2021
@nijel nijel closed this as completed in 308701f Nov 23, 2021
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Projects
None yet
Development

No branches or pull requests

2 participants