Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Glossary Terms by importing a TBX file #6614

Closed
ilocit opened this issue Sep 30, 2021 · 6 comments
Closed

Adding Glossary Terms by importing a TBX file #6614

ilocit opened this issue Sep 30, 2021 · 6 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Projects
Milestone

Comments

@ilocit
Copy link
Contributor

ilocit commented Sep 30, 2021

When trying to add new terms to an existing glossary, no new strings / terms will be added.

  1. Create a TBX file
  2. Go to your existing project and glossary
  3. Select the source or any target language
  4. Go to Files / Upload translation
  5. Select your file and select Add new strings

Expectation:

Existing terms will be updated, new terms will be added.

Actual result:

image

@nijel
Copy link
Member

nijel commented Oct 5, 2021

Are there any translated strings in the TBX? The import currently only looks for translated ones...

@ilocit
Copy link
Contributor Author

ilocit commented Oct 5, 2021

No, they are new term which should be translated online.

@nijel
Copy link
Member

nijel commented Oct 7, 2021

Okay, this situation is currently not covered - only translated strings are being imported.

@nijel nijel added the enhancement Adding or requesting a new feature. label Oct 7, 2021
@nijel nijel added this to TODO in Glossary via automation Oct 7, 2021
@ilocit
Copy link
Contributor Author

ilocit commented Oct 7, 2021

OK.
And what does the option "Add new strings" stand for then?
Or is there a workaround you could think of to import new terms?
Maybe downloading the current file, merging it with the new (additional terms) and uploading it again with "Replace existing translation file". But would that work for the source language?
I will try this. Thanks.

@ilocit
Copy link
Contributor Author

ilocit commented Oct 7, 2021

I can confirm that the proposed "workaround" does actually work.

  1. Download any language glossary from Weblate.
  2. Add new terms / merge with the TBX containing the new Terms (with or without translation)
  3. Upload as Replace existing translation file
  4. New terms are being added.

They will not be added as new terms to all languages, because the flag "terminology" is not set for the new terms after import, but at least they are there.

This can then be fixed using Bulk Edit to add the flag "terminology" to those new terms.

@nijel nijel self-assigned this Oct 27, 2021
@nijel nijel added this to the 4.9 milestone Oct 27, 2021
@nijel nijel closed this as completed in 2a161ac Oct 27, 2021
Glossary automation moved this from TODO to Done Oct 27, 2021
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
Glossary
  
Done
Development

No branches or pull requests

2 participants