Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign reviewer to GitHub pull requests #6697

Closed
ubuntudroid opened this issue Oct 19, 2021 · 6 comments
Closed

Assign reviewer to GitHub pull requests #6697

ubuntudroid opened this issue Oct 19, 2021 · 6 comments
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature.

Comments

@ubuntudroid
Copy link

Is your feature request related to a problem? If so, please describe.

When weblate creates pull requests in GitHub on the source repository they are not assigned to anyone. In our internal flow all pull requests need to be assigned to a reviewer - all our tooling relies heavily on this.

Describe the solution you'd like

It would be great if one could define a default reviewer in the version control settings in weblate.

Describe alternatives you've considered

I tried using GitHub actions like this one to auto-assign reviewers, but it doesn't work on PRs created by weblate - likely because the PR is created via some kind of API and not via the "regular GitHub UI flow"?

@nijel nijel added backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature. labels Oct 19, 2021
@github-actions
Copy link

This issue has been added to the backlog. It is not scheduled on the Weblate roadmap, but it eventually might be implemented.

In case you need this feature soon, please consider helping or push it by funding the development.

@nijel
Copy link
Member

nijel commented Oct 19, 2021

The pull request is indeed created via API, but still, it should trigger pull_request.opened event.

@ubuntudroid
Copy link
Author

Yeah, I honestly have no idea why it behaves differently than all our other pull requests... actually the only difference is that it comes from a fork while our other pull requests (where the assign-revierers-action works flawlessly) don't. 🤔

@nijel
Copy link
Member

nijel commented Oct 27, 2021

In that case, I guess it's because of secrets - the pull requests don't get access to GitHub secrets and thus can not auto-assign.

You can let Weblate push directly to your repo as well, just set push branch in component configuration. See https://docs.weblate.org/en/latest/admin/continuous.html#pushing-changes-from-weblate for more details.

@ubuntudroid
Copy link
Author

That worked! For everyone interested: This is the GitHub action I ended up using.

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants