Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic link for label is invalid for searching label when the label name is more than one word #6897

Closed
2 tasks done
Geeyun-JY3 opened this issue Dec 2, 2021 · 5 comments
Closed
2 tasks done

Automatic link for label is invalid for searching label when the label name is more than one word #6897

Geeyun-JY3 opened this issue Dec 2, 2021 · 5 comments
Assignees
@nijel
Labels
bug Something is broken. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.
Milestone
4.10.1

Comments

@Geeyun-JY3
Copy link
Collaborator

Geeyun-JY3 commented Dec 2, 2021 •
edited

Describe the issue

Automatic link for label is invalid for searching label when the label name is more than one word

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Go to a string with a label whose name is more than one word
  2. Click on the label
  3. The “No string matched your search!” alert appears

Expected behavior

The link is valid for searching that label in the component

Screenshots

image

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

Example: https://hosted.weblate.org/translate/gnucash/website/en/?checksum=e4ec522774aafadf

The automatic link for the Source needs review label is https://hosted.weblate.org/translate/gnucash/website/en/?q=label:Source%20needs%20review. But this is invalid for seaching this label and you will only get “No string matched your search!” alert after you clicking it. The link should be https://hosted.weblate.org/translate/gnucash/website/en/?q=label:"Source%20needs%20review".
@nijel nijel added bug Something is broken. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed. labels Dec 3, 2021
@nijel nijel added this to the 4.10 milestone Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@nijel nijel modified the milestones: 4.10, 4.10.1 Dec 16, 2021
@Al-0
Copy link

Al-0 commented Dec 20, 2021

I will look into this issue.

@nijel
Copy link
Member

nijel commented Dec 21, 2021

@Al-0 You're welcome!

@nijel
Copy link
Member

nijel commented Dec 22, 2021

@Al-0 As we're close to the milestone where this is supposed to be addressed, I will take over this issue. Please choose something else to work on 😉

@nijel nijel assigned nijel and unassigned Al-0 Dec 22, 2021
@nijel nijel closed this as completed in 253361e Dec 22, 2021
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
bug Something is broken. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.
Projects
None yet
Milestone
4.10.1
Development

No branches or pull requests
3 participants
@nijel @Geeyun-JY3 @Al-0