Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend search with comment_status field #7227

Closed
rhofer opened this issue Feb 9, 2022 · 3 comments
Closed

Extend search with comment_status field #7227

rhofer opened this issue Feb 9, 2022 · 3 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@rhofer
Copy link
Contributor

rhofer commented Feb 9, 2022

Describe the problem

Search allows translators to include the comment:TEXT field. When user notification is used, this field can be used as comment:@Username what results in a reduced list for which the user with Username has been explicitely mentioned. Currently, the result does not distinguish between resolved and unresolved comments. This makes it difficult for users to focus on comments which are still open / untreated.

Describe the solution you'd like

Introduce a search field comment_status:{resolved|unresolved}.

A user can focus on unresolved comments with explicite mentioning by querying

  • Custom search: comment:@Username AND comment_status:unresolved

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Feb 9, 2022

I think it makes more sense to search for unresolved comments by default. This is consistent that we have check: and dismissed_check: qualifiers.

@nijel nijel added the enhancement Adding or requesting a new feature. label Feb 9, 2022
@nijel nijel added this to the 4.11 milestone Feb 9, 2022
@nijel nijel self-assigned this Feb 9, 2022
@nijel nijel closed this as completed in a7ca23c Feb 9, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@rhofer
Copy link
Contributor Author

rhofer commented Feb 9, 2022

Good idea. Many thanks for that quick implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants