-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weblate outputs empty Android string entities #7248
Comments
This issue has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
This still needs to be triaged. |
The issue you've reported needs to be addressed in the translate-toolkit. Please file the issue there, and include links to any relevant specifications about the formats (if applicable). |
This happens in case the string translation is being removed in Weblate. In case you don't want such entries to be present, you can use Remove blank strings add-on. If this is generally desired for this file format, it should be probably addressed in the translate-toolkit. |
Thanks, the add-on works. translate/translate#3281 seems to partially address the plurals issue, but it may be possible for Weblate to enforce validation on their end to require all quantities. |
Not writing some strings to the files by Weblate should be covered by #3745. Back to the original topic - is this general with the Android strings, or is this behavior specific to your use case? |
Thank you for your report; the issue you have reported has just been fixed.
|
This should be the general desired behaviour, yes. Empty strings are invalid (but the system may still fall back to another locale's version), while incomplete plurals will crash apps. |
Okay, I've made the add-on installed by default for the Android files. |
Describe the issue
We were notified in https://github.com/tachiyomiorg/tachiyomi/pull/6607 (c.f. the PR diff) that the strings sometimes contain invalid empty string entities, e.g.,
I already tried
Steps to reproduce the behavior
Unsure, seems to be the existing Weblate behavior
Expected behavior
Screenshots
No response
Exception traceback
No response
How do you run Weblate?
weblate.org service
Weblate versions
No response
Weblate deploy checks
No response
Additional context
The related project: https://hosted.weblate.org/projects/tachiyomi/strings/
The text was updated successfully, but these errors were encountered: