Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zh_CN/zh_TW/zh_HK/zh_SG instead of zh_Hans/zh_Hant for Chinese language code #7437

Closed
lumingzh opened this issue Mar 28, 2022 · 7 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@lumingzh
Copy link

Describe the problem

The apps using zh_Hans from weblate can't display Chinese UI on GNOME, not test other desktop environment. Collision changed from zh_Hans to zh_CN and works normal now.

Describe the solution you'd like

Use zh_CN/zh_TW/zh_HK/zh_SG for Chinese.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

OS: Fedora Silverblue 35
DE: Gnome Shell 41
APP: Installed from flathub as flatpak

@nijel
Copy link
Member

nijel commented Mar 29, 2022

There is no one solution that would fit all use cases. That's why there is Language code style, see Adding new translations for more info. What might make sense is to add another option there that would cover POSIX style identifiers with legacy codes for Chinese.

@nijel nijel added the enhancement Adding or requesting a new feature. label Mar 29, 2022
@nijel nijel self-assigned this Mar 29, 2022
@nijel nijel added this to the 4.12 milestone Mar 29, 2022
@nijel nijel closed this as completed in 0e12248 Mar 29, 2022
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@sonnyp
Copy link

sonnyp commented Mar 29, 2022

@nijel is this something "Linux" could fix on their side? Like fallback to zh_CN for zh_Hans and vice versa ?

Where would that be - glibc?

@nijel
Copy link
Member

nijel commented Mar 29, 2022

This is just about naming of translation files created in Weblate. Once the file exists, Weblate doesn't care whether it is called zh_CN or zh_Hans.

@sonnyp
Copy link

sonnyp commented Mar 29, 2022

I understand. I meant fixing on a higher level – where Weblate is not involved.

I guess I'm looking for the right place to file a feature request so that this doesn't happen in the first place if the Linux stack understands that zh_CN = zh_Hans and so on.

@nijel
Copy link
Member

nijel commented Mar 29, 2022

Ah, that might be indeed in glibc.

@sonnyp
Copy link

sonnyp commented May 14, 2022

For the record and in case someone is interested in picking this up, Fedora already requested this from glibc and the developers basically said "yes but tricky”, which I understand as "ok if someone is willing to put the effort into it".

https://sourceware.org/legacy-ml/libc-alpha/2019-10/msg00358.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants