Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Automatically translated" label got applied to source language strings after running automatic translations for another language #7504

Closed
2 tasks done
WofWca opened this issue Apr 16, 2022 · 9 comments
Labels
wontfix Nobody will work on this.

Comments

@WofWca
Copy link
Contributor

WofWca commented Apr 16, 2022

Describe the issue

5 days ago I used Automatic translation with "Add as translation" for, IIRC, unfinished strings in another language and later noticed that the "Automatically translated" label also got applied to the source (English) language strings, which seems wrong to me.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Did not try again, but apparently:

  1. Go to a non-source language that has unfinished strings
  2. Tools -> Automatic translation
  3. Select "Add as needing edit", "Unfinished strings", "Machine translation".
  4. DeepL, Google Translate, LibreTranslate, Microsoft Translator, Weblate Translation Memory
  5. "Apply", then wait for it to finish.
  6. Go to the source language and see that the "Automatically translated" label got applied to some strings.

Expected behavior

"Automatically translated" label got applied only to the strings in the language that I used automatic translation for.

Screenshots

"Automatically translated" label got applied to the strings in the language that I used automatic translation for and to the corresponding strings of the source language.

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

The one that was deployed on hosted.weblate.org 5 days ago.

Weblate deploy checks

No response

Additional context

No response

@burner1024
Copy link
Contributor

As I learned the hard way, labels are a property of source strings. Same with explanations.

@WofWca
Copy link
Contributor Author

WofWca commented Apr 22, 2022

Oh. That explains it. Confusing. I guess then we need to ask for per-language labels first? Is #5447 the one?

@burner1024
Copy link
Contributor

I don't think that's the one.
All I can say is that seeing "auto translated" label in other languages sure is misleading, and it would be nice to be able to mark translation units individually.

@nijel
Copy link
Member

nijel commented Apr 23, 2022

@burner1024
Copy link
Contributor

So labels can be set on translation units without setting them on source units? Certainly doesn't work that way for me.

@nijel
Copy link
Member

nijel commented Apr 24, 2022

This is currently used only for Automatically translated labels. User labels can be set only for source string.

@WofWca
Copy link
Contributor Author

WofWca commented Apr 24, 2022

Then I must have edited the labels after. Should we close then? Or edit? Or close and create a new one?

@nijel
Copy link
Member

nijel commented Apr 26, 2022

Having a link to the affected strings could help in diagnosing this next time...

@github-actions
Copy link

github-actions bot commented May 7, 2022

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Nobody will work on this.
Projects
None yet
Development

No branches or pull requests

3 participants