Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for <link rel="(next|prev) #7584

Closed
WofWca opened this issue May 3, 2022 · 6 comments
Closed

Add tests for <link rel="(next|prev) #7584

WofWca opened this issue May 3, 2022 · 6 comments
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.

Comments

@WofWca
Copy link
Contributor

WofWca commented May 3, 2022

Describe the problem

There are no tests for #7558, #7573.

Describe the solution you'd like

Add tests for this. But I'm not sure where to put them. Can you give an advice?

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented May 3, 2022

The translation editor is tested in weblate/trans/tests/test_edit.py. For #7573 probabl in the tests for individual views where link should be visible.

@github-actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label May 14, 2022
@nijel nijel added enhancement Adding or requesting a new feature. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. and removed wontfix Nobody will work on this. labels May 17, 2022
@github-actions
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@enrique9318
Copy link

Hi, can I help on this? is there any additional info that I might need before starting?

@WofWca
Copy link
Contributor Author

WofWca commented Sep 8, 2022

Oh. That <link> is actually gone now 🦀🦀

Sorry

@WofWca WofWca closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.
Projects
None yet
Development

No branches or pull requests

3 participants