Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github PRs not working with only PAT on docker #7593

Closed
2 tasks done
Apfelwurm opened this issue May 4, 2022 · 3 comments
Closed
2 tasks done

Github PRs not working with only PAT on docker #7593

Apfelwurm opened this issue May 4, 2022 · 3 comments
Assignees
Labels
enhancement Adding or requesting a new feature.

Comments

@Apfelwurm
Copy link

Describe the issue

Hey, i have installed a dockerized weblate and it seems i'm not able to understand why my Github PRs are not working.
I have created an gh account and generated a PAT and have setted WEBLATE_GITHUB_USERNAME and WEBLATE_GITHUB_TOKEN accordingly.
I have created a project and a component inside with GitHub pull request as VCS, the https url of the public repository and the main repo branch. The push url and push branch are empty, since i want it to fork the project and open a pr (which worked like that on the hosted weblate instance).
If weblate tries to commit, i get the error no such identity: /app/data/ssh/id_rsa: No such file or directory which is true, i have no ssh key in place. Just for my understanding: do i really need an ssh key of the user if i have a PAT in place or is this some kind of missconfiguration i made?
The documentation does not mention the need of an ssh key here so i'm a bit confused.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. create public github repository in an organisation
  2. create a github user that is not part of the organisation
  3. create a personal access token for this user
  4. deploy dockerized weblate and set WEBLATE_GITHUB_USERNAME and WEBLATE_GITHUB_TOKEN
  5. create a project and a project component with the public http url of the repo and leave the push branch and push url empty
  6. make changes in weblate and try to commit them

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

  • Weblate: 4.12.1
  • Django: 4.0.4
  • siphashc: 2.1
  • translate-toolkit: 3.6.1
  • lxml: 4.7.1
  • Pillow: 9.1.0
  • bleach: 5.0.0
  • python-dateutil: 2.8.2
  • social-auth-core: 4.2.0
  • social-auth-app-django: 5.0.0
  • django-crispy-forms: 1.14.0
  • oauthlib: 3.2.0
  • django-compressor: 4.0
  • djangorestframework: 3.13.1
  • django-filter: 21.1
  • django-appconf: 1.0.5
  • user-agents: 2.2.0
  • filelock: 3.6.0
  • jellyfish: 0.9.0
  • openpyxl: 3.0.9
  • celery: 5.2.6
  • kombu: 5.2.4
  • translation-finder: 2.12
  • weblate-language-data: 2022.2
  • html2text: 2020.1.16
  • pycairo: 1.21.0
  • pygobject: 3.42.1
  • diff-match-patch: 20200713
  • requests: 2.27.1
  • django-redis: 5.2.0
  • hiredis: 2.0.0
  • sentry_sdk: 1.5.10
  • Cython: 0.29.28
  • misaka: 2.1.1
  • GitPython: 3.1.27
  • borgbackup: 1.2.0
  • pyparsing: 3.0.8
  • pyahocorasick: 1.4.4
  • python-redis-lock: 3.7.0
  • charset-normalizer: 2.0.12
  • Python: 3.10.4
  • Git: 2.30.2
  • psycopg2: 2.9.3
  • psycopg2-binary: 2.9.3
  • phply: 1.2.5
  • ruamel.yaml: 0.17.21
  • tesserocr: 2.5.2
  • akismet: 1.1
  • boto3: 1.22.3
  • zeep: 4.1.0
  • aeidon: 1.11
  • iniparse: 0.5
  • mysqlclient: 2.1.0
  • Mercurial: 6.1.1
  • git-svn: 2.30.2
  • git-review: 2.3.1
  • Redis server: 6.2.7
  • PostgreSQL server: 14.2
  • Database backends: django.db.backends.postgresql
  • Cache backends: default:RedisCache, avatar:FileBasedCache
  • Email setup: django.core.mail.backends.smtp.EmailBackend: v49347.volzit.de
  • OS encoding: filesystem=utf-8, default=utf-8
  • Celery: redis://cache:6379/1, redis://cache:6379/1, regular
  • Platform: Linux 4.15.0-176-generic (x86_64)

Weblate deploy checks

System check identified some issues:

INFOS:
?: (weblate.I021) Error collection is not set up, it is highly recommended for production use
	HINT: https://docs.weblate.org/en/weblate-4.12.1/admin/install.html#collecting-errors
?: (weblate.I028) Backups are not configured, it is highly recommended for production use
	HINT: https://docs.weblate.org/en/weblate-4.12.1/admin/backup.html

System check identified 2 issues (1 silenced).

Additional context

No response

@Apfelwurm Apfelwurm added the question This is more a question for the support than an issue. label May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger.

In case your question is already answered, making a donation is the right way to say thank you!

@Apfelwurm Apfelwurm changed the title Github PRs not working Github PRs not working with only PAT on docker May 4, 2022
@nijel
Copy link
Member

nijel commented May 5, 2022

You are pushing to a SSH URL and you need they key in that case. But it should have been generated automatically by Weblate...

@nijel nijel self-assigned this May 5, 2022
@nijel nijel added enhancement Adding or requesting a new feature. and removed question This is more a question for the support than an issue. labels May 5, 2022
@nijel nijel closed this as completed in ff01101 May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants