Why Variant relate on source string instead of key (id)?

[antonkomarev]

Describe the issue

Why variants uses mutable source string value as relation identifier instead of immutable Translation key (XLIFF id attribute)? Is it bug or made intentionally?

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

1. Create translation string with key = example and translation This is example
2. Create variant of the string example with key = example_one and translation This is example One
3. Create variant of the string example with key = example_two and translation This is example Two
4. Export XLIFF file
5. Look on weblate-flags attribute

<trans-unit xml:space="preserve" approved="yes" id="example">
  <source>This is example</source>
  <target state="translated">This is example</target>
</trans-unit>

<trans-unit xml:space="preserve" approved="yes" id="example_one" weblate-flags="variant:&quot;This is example&quot;">
  <source>This is example One</source>
  <target state="translated">This is example One</target>
</trans-unit>

<trans-unit xml:space="preserve" approved="yes" id="example_two" weblate-flags="variant:&quot;This is example&quot;">
  <source>This is example Two</source>
  <target state="translated">This is example Two</target>
</trans-unit>

Expected behavior

<trans-unit xml:space="preserve" approved="yes" id="example">
  <source>This is example</source>
  <target state="translated">This is example</target>
</trans-unit>

<trans-unit xml:space="preserve" approved="yes" id="example_one" weblate-flags="variant:example">
  <source>This is example One</source>
  <target state="translated">This is example One</target>
</trans-unit>

<trans-unit xml:space="preserve" approved="yes" id="example_two" weblate-flags="variant:example">
  <source>This is example Two</source>
  <target state="translated">This is example Two</target>
</trans-unit>

How do you run Weblate?

Docker container

Weblate versions

Weblate 4.12.2

[github-actions]

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger.

In case your question is already answered, making a donation is the right way to say thank you!

[burner1024]

There's no ids in PO format, for example.
Although I did expect variants to be linked by unit ids or something. Right now, with every source string update, I guess variants have to be re-linked, and given that it scales pretty badly, this could be a major issue in setups that use lots of variants.

[nijel]

When using keys, it might be better to use automated variants.

[antonkomarev]

When using keys, it might be better to use automated variants.

Then variants flagged as variant in UI but not does not flagged in exported XLIFF file in any way. Is that correct behavior?

<trans-unit xml:space="preserve" approved="yes" id="example">
  <source>This is example</source>
  <target state="translated">This is example</target>
</trans-unit>

<trans-unit xml:space="preserve" approved="yes" id="example_one">
  <source>This is example One</source>
  <target state="translated">This is example One</target>
</trans-unit>

<trans-unit xml:space="preserve" approved="yes" id="example_two">
  <source>This is example Two</source>
  <target state="translated">This is example Two</target>
</trans-unit>

[nijel]

Yes, that's correct.

[github-actions]

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!