When trying to add a suggestion that is == current translation, it says "suggestion already exists", even if there are actually none

[WofWca]

Describe the issue

Sounds nitpicky, but it confused me when is was editing glossary since there's an "Explanation" text area which is in place of where the translation text area usually is on non-glossary items. Maybe this also needs to be changed.

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

No response

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

Code:

weblate/weblate/trans/views/edit.py

Lines 288 to 297 in 4b2e079

	# Create the suggestion
	result = Suggestion.objects.add(
	unit,
	join_plural(form.cleaned_data["target"]),
	request,
	request.user.has_perm("suggestion.vote", unit),
	)
	if not result:
	messages.error(request, _("Your suggestion already exists!"))
	return result

weblate/weblate/trans/models/suggestion.py

Lines 47 to 48 in d92daad

	if unit.translated and unit.target == target:
	return False

[github-actions]

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

[acharyasourav]

hey I'm new to opensource and would like to work on it can you please tell what needs to be done?

[WofWca]

What is it that you don't understand? There are links to the responsible code in the issue description.

[acharyasourav]

I did check out the code what i meant to ask is do you have any idea on what should be changed and what should it rather say?

[nijel]

The problem is that there is same error message used for case where suggestion matches existing suggestion (where it correct) and when it matches existing translation (where the message is confusing).