Sort button should indicate the current sorting order (ascending or descending)

[Geeyun-JY3]

Describe the issue

The sort button is always the same (sort-ascending) after the page is loaded.

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

1. Go to any page with the sort button
2. Click the sort button
3. See that the order is changed but the sort button wouldn't change to another(sort-descending to sort-descending or verse vice) after the page is loaded

Expected behavior

The sort button should indicate the current sorting order (ascending or descending).

Screenshots

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

[github-actions]

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

[ParthS007]

@nijel Can you please point me to code of the desired sort button or you can also point me to instructions to find this in UI. Thanks

Edit 1: I found the button. Should we keep a tool tip for showing the current order, this is how tooltip looks like.

[nijel]

I think the issue is not only about missing tooltip, but that the button looks same regardless sorting order.

[ParthS007]

@nijel I looked into it more, the logic here seems alright. The root cause is re-render of the page on every click of change in sorting order. We receive a preset value for sort_dropdown_value and we don't persist the sort order.

What do you think of adding another param in the request for the current sort order and using that for evaluating the class(asc, desc) of toggle.

Edit 2: Specifically, I mean adding a sort_order field in UserSearchForm and SearchForm, I will update the PR with that and please let me know if you have any other suggestions.

Edit 3: After investigating a bit more, the toggle seems to happen here actually.

[nijel]

The order is implied in the order string - for example '-priority' and 'priority'. That is the logic implemented here:

weblate/weblate/static/loader-bootstrap.js

Lines 934 to 955 in 531881d

	// Show the correct toggle button
	if ($(".sort-field").length) {
	var sort_name = $("#query-sort-dropdown span.search-label").text();
	var sort_dropdown_value = $(".sort-field li a")
	.filter(function () {
	return $(this).text() == sort_name;
	})
	.data("sort");
	var sort_value = $("#id_sort_by").val();
	if (sort_dropdown_value) {
	if (
	sort_value.replace("-", "") === sort_dropdown_value.replace("-", "") &&
	sort_value !== sort_dropdown_value
	) {
	$("#query-sort-toggle .asc").hide();
	$("#query-sort-toggle .desc").show();
	} else {
	$("#query-sort-toggle .desc").hide();
	$("#query-sort-toggle .asc").show();
	}
	}
	}

Maybe it's just not working properly or is not triggered, I think this used to work in the past.

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.