Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weblate misplaces the merge request message #8007

Closed
2 tasks done
lexisother opened this issue Aug 15, 2022 · 2 comments
Closed
2 tasks done

Weblate misplaces the merge request message #8007

lexisother opened this issue Aug 15, 2022 · 2 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@lexisother
Copy link

Describe the issue

When configuring Weblate to create merge requests to a GitHub repository, you are given the option to customize the message it adds.

However, instead of adding it as the PR description, it tries to set this entire message as the PR title.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Configure Weblate to create merge requests.
  2. Let it create a merge request.

Expected behavior

The "merge request message" is set as the PR description, not the PR title.

Screenshots

image

image

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

  • Weblate: 4.12
  • Django: 4.0.4
  • siphashc: 2.1
  • translate-toolkit: 3.6.1
  • lxml: 4.7.1
  • Pillow: 9.1.0
  • bleach: 5.0.0
  • python-dateutil: 2.8.2
  • social-auth-core: 4.2.0
  • social-auth-app-django: 5.0.0
  • django-crispy-forms: 1.14.0
  • oauthlib: 3.2.0
  • django-compressor: 3.1
  • djangorestframework: 3.13.1
  • django-filter: 21.1
  • django-appconf: 1.0.5
  • user-agents: 2.2.0
  • filelock: 3.6.0
  • jellyfish: 0.9.0
  • openpyxl: 3.0.9
  • celery: 5.2.6
  • kombu: 5.2.4
  • translation-finder: 2.12
  • weblate-language-data: 2022.2
  • html2text: 2020.1.16
  • pycairo: 1.21.0
  • pygobject: 3.42.1
  • diff-match-patch: 20200713
  • requests: 2.27.1
  • django-redis: 5.2.0
  • hiredis: 2.0.0
  • sentry_sdk: 1.5.10
  • Cython: 0.29.28
  • misaka: 2.1.1
  • GitPython: 3.1.27
  • borgbackup: 1.2.0
  • pyparsing: 3.0.8
  • pyahocorasick: 1.4.4
  • python-redis-lock: 3.7.0
  • charset-normalizer: 2.0.12
  • Python: 3.10.4
  • Git: 2.30.2
  • psycopg2: 2.9.3
  • psycopg2-binary: 2.9.3
  • phply: 1.2.5
  • ruamel.yaml: 0.17.21
  • tesserocr: 2.5.2
  • akismet: 1.1
  • boto3: 1.21.44
  • zeep: 4.1.0
  • aeidon: 1.11
  • iniparse: 0.5
  • mysqlclient: 2.1.0
  • Mercurial: 6.1.1
  • git-svn: 2.30.2
  • git-review: 2.3.1
  • Redis server: 6.2.7
  • PostgreSQL server: 14.5
  • Database backends: django.db.backends.postgresql
  • Cache backends: default:RedisCache, avatar:FileBasedCache
  • Email setup: django.core.mail.backends.smtp.EmailBackend: smtp.gmail.com
  • OS encoding: filesystem=utf-8, default=utf-8
  • Celery: redis://cache:6379/1, redis://cache:6379/1, regular
  • Platform: Linux 5.15.0-1013-oracle (aarch64)

Weblate deploy checks

System check identified some issues:

WARNINGS:
?: (security.W004) You have not set a value for the SECURE_HSTS_SECONDS setting. If your entire site is served only over SSL, you may want to consider setting a value and enabling HTTP Strict Transport Security. Be sure to read the documentation first; enabling HSTS carelessly can cause serious, irreversible problems.
?: (security.W008) Your SECURE_SSL_REDIRECT setting is not set to True. Unless your site should be available over both SSL and non-SSL connections, you may want to either set this setting True or configure a load balancer or reverse-proxy server to redirect all connections to HTTPS.
?: (security.W012) SESSION_COOKIE_SECURE is not set to True. Using a secure-only session cookie makes it more difficult for network traffic sniffers to hijack user sessions.
?: (security.W018) You should not have DEBUG set to True in deployment.

INFOS:
?: (weblate.I021) Error collection is not set up, it is highly recommended for production use
        HINT: https://docs.weblate.org/en/weblate-4.12/admin/install.html#collecting-errors
?: (weblate.I028) Backups are not configured, it is highly recommended for production use
        HINT: https://docs.weblate.org/en/weblate-4.12/admin/backup.html
?: (weblate.I031) New Weblate version is available, please upgrade to 4.13.1.
        HINT: https://docs.weblate.org/en/weblate-4.12/admin/upgrade.html

System check identified 7 issues (1 silenced).

Additional context

No response

@nijel nijel added the bug Something is broken. label Aug 16, 2022
@nijel nijel self-assigned this Aug 16, 2022
@nijel nijel added this to the 4.12.1 milestone Aug 16, 2022
@nijel
Copy link
Member

nijel commented Aug 16, 2022

This should be already fixed in 4.12.1, by b2f22da.

@nijel nijel closed this as completed Aug 16, 2022
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants