Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't showing new keys for iOS localization strings after update from remote repo #8012

Closed
2 tasks done
madlax19 opened this issue Aug 17, 2022 · 2 comments
Closed
2 tasks done
Assignees
Labels
bug Something is broken.
Milestone

Comments

@madlax19
Copy link

Describe the issue

After update from remote repo if iOS Localizable.strings file contains duplicate keys, new keys are not displayed in UI and can't be localized. But downloaded localizable.strings file from UI it contains these missed keys.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Update remote repo with iOS localizable.strings files by adding new strings with same key like this :
"some_new_key_1" = "Some new value 1";
"some_new_key_duplicate" = "Some new duplicate value";
"some_new_key_duplicate" = "Some new duplicate value";
"some_new_key_2" = "Some new value 2";
"some_new_key_3" = "Some new value 3";
  1. Into component Manage go to Repository maintenance and update component from remote repo by pressing Update button
  2. Go to languages list and select Language what has been updated
  3. Try to search for new keys

Expected behavior

User interface should displays the new keys even they are duplicated in remote source file

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

4.13.1

Weblate deploy checks

No response

Additional context

No response

@nijel nijel self-assigned this Aug 17, 2022
@nijel nijel added the bug Something is broken. label Aug 17, 2022
@nijel nijel added this to the 4.14 milestone Aug 17, 2022
@nijel
Copy link
Member

nijel commented Aug 17, 2022

Weblate 4.13 doesn't properly report duplicate keys and fails to update in that case.

This is already fixed by 309b09a.

@nijel nijel closed this as completed Aug 17, 2022
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants