Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Azure Login afterwards #8052

Closed
2 tasks done
reloxx13 opened this issue Aug 24, 2022 · 3 comments
Closed
2 tasks done

Adding Azure Login afterwards #8052

reloxx13 opened this issue Aug 24, 2022 · 3 comments
Labels
duplicate Similar issue or pull request already exists. question This is more a question for the support than an issue.

Comments

@reloxx13
Copy link
Contributor

reloxx13 commented Aug 24, 2022

Describe the issue

Heya,

i have a weblate instance running with only email login.
Now i want to add Azure. The users are not linkted to Azure now.

If they login with azure now, it says "email already in use". I would expect that the azure login would match and use the existing user instead of creating a new user.

Is the default auth pipeline wrong? as it has "associate_user" and "associate_by_email". The pipeline task for duplicate check should only be triggered when creating a new user, it seems to run too early in the pipeline. but i dont know which one is the duplicate check.

PS: i know the users should link their accounts manual now in their profile settings, but you know... :D

# Social auth settings
SOCIAL_AUTH_PIPELINE = (
    "social_core.pipeline.social_auth.social_details",
    "social_core.pipeline.social_auth.social_uid",
    "social_core.pipeline.social_auth.auth_allowed",
    "social_core.pipeline.social_auth.social_user",
    "weblate.accounts.pipeline.store_params",
    "weblate.accounts.pipeline.verify_open",
    "social_core.pipeline.user.get_username",
    "weblate.accounts.pipeline.require_email",
    "social_core.pipeline.mail.mail_validation",
    "weblate.accounts.pipeline.revoke_mail_code",
    "weblate.accounts.pipeline.ensure_valid",
    "weblate.accounts.pipeline.remove_account",
    "social_core.pipeline.social_auth.associate_by_email",
    "weblate.accounts.pipeline.reauthenticate",
    "weblate.accounts.pipeline.verify_username",
    "social_core.pipeline.user.create_user",
    "social_core.pipeline.social_auth.associate_user",
    "social_core.pipeline.social_auth.load_extra_data",
    "weblate.accounts.pipeline.cleanup_next",
    "weblate.accounts.pipeline.user_full_name",
    "weblate.accounts.pipeline.store_email",
    "weblate.accounts.pipeline.notify_connect",
    "weblate.accounts.pipeline.password_reset",
)

Another problem is, that the saved user id is not the user id azure shows, so i cannot even create those links manual.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Create a user with email
logout
login with azure now with same email

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Git checkout

Weblate versions

4.13

Weblate deploy checks

No response

Additional context

No response

@reloxx13 reloxx13 added the question This is more a question for the support than an issue. label Aug 24, 2022
@nijel nijel added the duplicate Similar issue or pull request already exists. label Aug 24, 2022
@nijel
Copy link
Member

nijel commented Aug 24, 2022

Duplicate of #7666

@nijel nijel marked this as a duplicate of #7666 Aug 24, 2022
@nijel nijel closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
@reloxx13
Copy link
Contributor Author

Duplicate of #7666

yeah i just found it now

@github-actions
Copy link

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger.

In case your question is already answered, making a donation is the right way to say thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Similar issue or pull request already exists. question This is more a question for the support than an issue.
Projects
None yet
Development

No branches or pull requests

2 participants