Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error/warning in component when update errors occur #8069

Closed
derkoe opened this issue Aug 31, 2022 · 4 comments
Closed

Show error/warning in component when update errors occur #8069

derkoe opened this issue Aug 31, 2022 · 4 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@derkoe
Copy link
Contributor

derkoe commented Aug 31, 2022

Describe the problem

Errors are not shown in the UI when the source files change in the repository and contain errors.

For example if you have component with Java properties and add a duplicate entry in the source file you'll get an error in the Weblate instance log:

celery-celery stderr | [2022-08-31 06:20:15,500: WARNING/13484] angular-spring-heroes/webapp: skipping update due to error in parsing template: Duplicate id_hash for unit test=Test

When such an error occurs the translation component is not updated and the error is not shown anywhere.

Describe the solution you'd like

It would be great to see update errors for translation components in the user interface. Another option would be to send e-mails to all project administrators.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Aug 31, 2022

This was already fixed in 4.14

@tomkolp
Copy link
Contributor

tomkolp commented Aug 31, 2022

Which fix is ​​this? I think I have a similar error. Come along with me too, I have a version:

4.14.1-dev — 82db0b5cffaa54757ee80dc8a201722be9099321

4.14.1-dev — [82db0b5](https://github.com/WeblateOrg/weblate/commits/82db0b5cffaa54757ee80dc8a201722be9099321)

Sentry: https://sentry.io/share/issue/d39381c99af44661805f042648f36ca8/

@nijel nijel added this to the 4.14 milestone Aug 31, 2022
@nijel nijel self-assigned this Aug 31, 2022
@nijel nijel added the bug Something is broken. label Aug 31, 2022
@nijel
Copy link
Member

nijel commented Aug 31, 2022

This validation was completely removed in #7994

@nijel nijel closed this as completed Aug 31, 2022
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

3 participants