Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx link-checker complains about redirects #8206

Closed
2 tasks done
comradekingu opened this issue Oct 12, 2022 · 3 comments
Closed
2 tasks done

Sphinx link-checker complains about redirects #8206

comradekingu opened this issue Oct 12, 2022 · 3 comments
Assignees
Labels
documentation Improvements or additions to the documentation.
Milestone

Comments

@comradekingu
Copy link
Contributor

comradekingu commented Oct 12, 2022

Describe the issue

https://github.com/comradekingu/Weblate/actions/runs/3231846508/jobs/5291803739

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Make PR touching the docs
It runs through every link, throwing (semi) errors

Expected behaviour

Expected it to clear with no issues introduced.
Possible if it is all cleaned, kept up to date, and never fouled by new PRs.

Alternatively, upgrading from Sphinx v4.5.0 to v5.2.3
from https://github.com/sphinx-doc/sphinx/releases might help.
10 versions behind seems like something must have happened.

sphinx-doc/sphinx#9894 From 4.4.0 linkcheck: add option linkcheck_exclude_documents to disable link checking in matched documents.
sphinx-doc/sphinx#7055 From 2.4.0 linkcheck: redirect is treated as an error
sphinx-doc/sphinx#5208 From 3.2.0 linkcheck: Support checks for local links

Seems to be the relevant ones

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

@Geeyun-JY3 Can you fix this? :)

@comradekingu comradekingu changed the title Link-checker complains about redirects Sphinx link-checker complains about redirects Oct 12, 2022
@Geeyun-JY3
Copy link
Collaborator

I do not know how to fix it.

@nijel nijel self-assigned this Oct 12, 2022
@nijel nijel added the documentation Improvements or additions to the documentation. label Oct 12, 2022
@nijel nijel added this to the 4.13 milestone Oct 12, 2022
@nijel
Copy link
Member

nijel commented Oct 12, 2022

The redirects are warnings, errors are elsewhere.

Also, it is easier to read via GitHub: https://github.com/comradekingu/Weblate/actions/runs/3231846508

The error itself has been already fixed in c86fa56

@nijel nijel closed this as completed Oct 12, 2022
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation.
Projects
None yet
Development

No branches or pull requests

3 participants