Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor placeholders check to use format checks base #8416

Open
nijel opened this issue Dec 2, 2022 · 0 comments
Open

Refactor placeholders check to use format checks base #8416

nijel opened this issue Dec 2, 2022 · 0 comments
Labels
enhancement Adding or requesting a new feature. help wanted Extra attention is needed.

Comments

@nijel
Copy link
Member

nijel commented Dec 2, 2022

Describe the problem

The logic in both checks is basically same, and it also shares logic for plurals since 883b13a (see #8382).

Describe the solution you'd like

Reuse BaseFormatCheck logic in PlaceholderCheck class.

Describe alternatives you've considered

Currently, the code is more or less copied.

Screenshots

No response

Additional context

No response
@nijel nijel added enhancement Adding or requesting a new feature. help wanted Extra attention is needed. labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Adding or requesting a new feature. help wanted Extra attention is needed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nijel