Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components keep getting locked when using gerrit push #8588

Closed
2 tasks done
mikeNG opened this issue Jan 11, 2023 · 2 comments
Closed
2 tasks done

Components keep getting locked when using gerrit push #8588

mikeNG opened this issue Jan 11, 2023 · 2 comments
Assignees
Milestone

Comments

@mikeNG
Copy link

mikeNG commented Jan 11, 2023

Describe the issue

A lot of the times components get randomly locked because push to gerrit fails. The push doesn't fail due to an actual error but due to the way gerrit works with patchsets. Here is an example of an alert log:

remote: 
remote: Processing changes: refs: 1
remote: Processing changes: refs: 1, done            
To ssh://review.calyxos.org:29418/CalyxOS/platform_packages_apps_Firewall
 ! [remote rejected] HEAD -> refs/for/android13 (no new changes)
error: failed to push some refs to 'ssh://review.calyxos.org:29418/CalyxOS/platform_packages_apps_Firewall'
 (1)

As you can see when weblate tries to update a patchset on gerrit and there are no changes since last patchset, gerrit returns an error (no new changes)

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Set up a component with gerrit push
  2. Wait a few days with no new activity
  3. See error

Expected behavior

Weblate should handle that gracefully and not lock the component or send an alert when it gets ! [remote rejected] HEAD -> refs/for/x (no new changes) as a response from gerrit

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@weblateorg-sentry-integration

Sentry issue: WEBLATE-F9

@nijel nijel added this to the 4.15.1 milestone Jan 12, 2023
@nijel nijel self-assigned this Jan 12, 2023
@nijel nijel closed this as completed in a20c0ba Jan 12, 2023
@github-actions
Copy link

The issue you have reported is now resolved. If you don’t feel it’s right, please follow its labels to get a clue for further steps.

  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants