Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra commit with wrong author after changing source string #8691

Closed
2 tasks done
WofWca opened this issue Jan 28, 2023 · 2 comments
Closed
2 tasks done

Extra commit with wrong author after changing source string #8691

WofWca opened this issue Jan 28, 2023 · 2 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@WofWca
Copy link
Contributor

WofWca commented Jan 28, 2023

Describe the issue

git history says that I added a string translation, but it wasn't me. I only recently changed the source string.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Make someone else add a translation of several strings.
  2. Change the source string (English) of one of the strings translated in step 1.
  3. Go to "repository maintenance" and commit pending changes to the Weblate repo.
  4. There are now 3 commits (recent-to-older order):
`git log` output
00d381d Translated using Weblate (Polish)
diff --git a/pl/messages.json b/pl/messages.json
index 4b3a88b..ec9343e 100644
--- a/pl/messages.json
+++ b/pl/messages.json
@@ -34,5 +34,8 @@
        },
        "openLocalFile": {
                "message": "otwórz lokalny plik"
+       },
+       "soundedSpeed": {
+               "message": "Prędkość dźwięku"
        }
 }
9cc03d2 Translated using Weblate (Polish)
diff --git a/pl/messages.json b/pl/messages.json
index 314d29c..4b3a88b 100644
--- a/pl/messages.json
+++ b/pl/messages.json
@@ -4,5 +4,35 @@
        },
        "extensionDescription": {
                "message": "Oglądaj wykłady ~1,5x szybciej dzięki szybkiemu przewijaniu długich przerw miedzy zdaniami"
+       },
+       "enable": {
+               "message": "Włacz"
+       },
+       "resetToDefaults": {
+               "message": "Przywróć domyślne ustawienia"
+       },
+       "noSuitableElement": {
+               "message": "Nie znaleziono odpowiedniego elementu multimedialnego na stronie"
+       },
+       "silenceSpeed": {
+               "message": "Prędkość ciszy"
+       },
+       "relativeToSounded": {
+               "message": "w odniesieniu do prędkości dźwięku"
+       },
+       "absolute": {
+               "message": "bezwzględna"
+       },
+       "fileInputLabel": {
+               "message": "Przeciągnij plik / pliki\nalbo naciśnij tutaj aby wybrać"
+       },
+       "useExperimentalAlgorithm": {
+               "message": "Użyj eksperymentalnego algorytmu"
+       },
+       "contentScriptFail": {
+               "message": "Nie udało się uruchomić skryptu na tej stronie"
+       },
+       "openLocalFile": {
+               "message": "otwórz lokalny plik"
        }
 }
53089cc Translated using Weblate (English)
diff --git a/en/messages.json b/en/messages.json
index c9e5ba4..42da6c0 100644
--- a/en/messages.json
+++ b/en/messages.json
@@ -138,7 +138,7 @@
                "message": "When the current audio volume is below this value, speed up.\nOn the chart, this is the red 🟥 horizontal line. The blue 🟦 line is the current volume, so when the blue line is below the red,   it is considered to  silence."
        },
        "soundedSpeed": {
-               "message": "Sounded speed"
+               "message": "Regular speed"
        },
        "soundedSpeedTooltip": {
                "message": "The speed at which we play the video when it's currently NOT silent, the \"normal\" speed.\nOn the chart, the parts that were played at this speed have green 🟩 background."
8b6359c Translated using Weblate (Russian)

Expected behavior

There's no that latest commit, and its change is squashed in the previous one.

Screenshots

History of the string:

image

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

weblate-4.15.2-111-g42190855d3

Weblate deploy checks

No response

Additional context

No response

@nijel nijel added the bug Something is broken. label Jan 28, 2023
@nijel nijel added this to the 4.16 milestone Jan 28, 2023
@nijel
Copy link
Member

nijel commented Jan 28, 2023

Commit pending is missing on translations when changing the source string, should be fixed.

@nijel nijel self-assigned this Jan 30, 2023
@nijel nijel closed this as completed in 693d700 Jan 30, 2023
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants