Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button disabled unexpectedly #8864

Closed
2 tasks done
timothyqiu opened this issue Mar 1, 2023 · 2 comments
Closed
2 tasks done

Save button disabled unexpectedly #8864

timothyqiu opened this issue Mar 1, 2023 · 2 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@timothyqiu
Copy link

Describe the issue

I'm an admin of the Godot Engine project.

Starting from last night, the "Save and continue" buttons is disabled for me, with the tooltip

Insufficient privileges for saving translations.

  • I am still able to upload translations.
  • The button is only enabled in the glossary component, and disabled in other components.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Go to a translation page.

Expected behavior

The "Save and continue" buttons is enabled.

Screenshots

image

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

I think it's probably related to this commit yesterday: 6468f66

The elif condition seems wrong according to logic described in the commit message.

When user can edit flags, but can not save translations, the Save button
is needed only for glossaries

{% elif user_can_edit_flags and not unit.translation.component.is_glossary %}
disabled="disabled"
title="{% trans "Insufficient privileges for saving translations." %}"
{% endif %}

@PascalRepond
Copy link

We have the same problem in our project https://hosted.weblate.org/translate/rero_plus/

@nijel nijel self-assigned this Mar 1, 2023
@nijel nijel added the bug Something is broken. label Mar 1, 2023
@nijel nijel added this to the 4.16 milestone Mar 1, 2023
@nijel nijel closed this as completed in 9f75260 Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

3 participants