Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permalink to zen mode #8882

Closed
2 tasks done
maboroshin opened this issue Mar 5, 2023 · 4 comments
Closed
2 tasks done

Add permalink to zen mode #8882

maboroshin opened this issue Mar 5, 2023 · 4 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@maboroshin
Copy link

maboroshin commented Mar 5, 2023

Describe the issue

In Zen mode, "Open in full editor" refers to a string in the following hash:

?q=state%3A<translated&offset=5

The offset appears to be the ordered number of search results. It points to a different string, perhaps because the cache changes over time. Probably.

This method changes the link to a different string. No one would expect a different string to open. Another problem is that giving the address to others may later refer to a different string.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Open some language in some project somewhere.
  2. Open "Unfinished strings" (This string is translated in the language you chose.)
  3. From the top right, enable Zen mode.
  4. Copy any string and the URL for "Open in full editor".
  5. Start translation.
  6. Open the copied URL a few hours later.
  7. A different string appears.

Expected behavior

"Open in full editor." refers to a unique string. See hash of checksum, not offset.

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Mar 6, 2023

That's why there is a permalink icon on top of the editor. If you share a link to untranslated strings, you should get a list of currently untranslated strings…

@maboroshin
Copy link
Author

In Zen mode, there are only offset links.

Sample URL:
https://hosted.weblate.org/zen/yattee/localizable-strings/ja/?q=state:%3Ctranslated

@nijel nijel self-assigned this Mar 6, 2023
@nijel nijel added this to the 4.16.2 milestone Mar 6, 2023
@nijel nijel added the enhancement Adding or requesting a new feature. label Mar 6, 2023
@nijel nijel changed the title Replacing references by offset Add permalink to zen mode Mar 6, 2023
@nijel nijel closed this as completed in bbbcb3e Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@maboroshin
Copy link
Author

maboroshin commented Nov 18, 2023

The editor's link is still referenced by offset. I don't know why relative links remain in use. "3rd untranslated string", this is not absolute. When we work long hours this link is always broken.

So now I need to do the following for each string. (1) Copy URL from this new permalink feature. (2) Open a new window. (3) Paste the permalink to address.

Comments and history can't be viewed from Weblate's list mode (ZEN mode). To improve the quality of the translation, it is necessarily necessary to open the editor URL. The current permalink functionality always requires the above 3 steps. Because of this hassle, translators will often use traditional editor links, maybe. So, offset shifts are often encountered. It will remain buggy link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants