Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable comments in project view #9089

Closed
2 tasks done
comradekingu opened this issue Apr 15, 2023 · 10 comments · Fixed by #11292
Closed
2 tasks done

Clickable comments in project view #9089

comradekingu opened this issue Apr 15, 2023 · 10 comments · Fixed by #11292
Assignees
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. ux Issues related to user experience.
Milestone

Comments

@comradekingu
Copy link
Contributor

comradekingu commented Apr 15, 2023

Describe the issue

Can't click comments here
https://hosted.weblate.org/projects/lomiri/

Can click comments here
https://hosted.weblate.org/projects/lomiri/lomiri-camera-app/

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Try to click comments from https://hosted.weblate.org/projects/lomiri/

Expected behavior

Opening all comments for the respective component.
https://hosted.weblate.org/search/lomiri/lomiri-camera-app/?q=has%3Acomment&sort_by=-priority%2Cposition&checksum= , but in the actual editor (so the comments can be read).

Screenshots

UBPorts/Lomiri
bilde
UBPorts/Lomiri/CameraApp
bilde

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

Would be nice with (unsolved) comments for the entire project
https://hosted.weblate.org/search/lomiri/?q=has%3Acomment&sort_by=-priority%2Cposition&checksum=
by clicking the top field.
, or language (without any projects selected).

I don't think people are awere comments are language-specific.

@nijel nijel added enhancement Adding or requesting a new feature. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. ux Issues related to user experience. labels Apr 17, 2023
@github-actions
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@ashishnagar19
Copy link

assign this to me.

@nijel
Copy link
Member

nijel commented May 26, 2023

@ashishnagar19 You're welcome. Don't hesitate to ask if something is unclear.

@ashishnagar19
Copy link

I am trying to install the weblate on my system, but in configuration part where i have to copy settings_examples.py to settings.py but settings.py is already there and it is different from settings_example.py. So tell me how to configure it.

@comradekingu
Copy link
Contributor Author

comradekingu commented May 27, 2023

At a guess you copy the content you want from settings_example.py into settings.py?

Just the defaults should be fine for what is a general shortcoming.

@luzpaz
Copy link
Contributor

luzpaz commented Jul 14, 2023

@ashishnagar19 any progress?

@BC46
Copy link
Contributor

BC46 commented Mar 12, 2024

May I please work on this issue?

@nijel
Copy link
Member

nijel commented Mar 12, 2024

@BC46 Yes, you're welcome.

@BC46
Copy link
Contributor

BC46 commented Mar 25, 2024

I have a question. In the source code I can see that the list-objects-number.html view component is responsible for determining whether the numbers inside the table should be clickable. Ensuring the translate_url is defined on the components page would not only make the comments clickable, but also all other table numbers because those make use of list-objects-number.html too. Moreover, this approach would change the folder icon next to each table row into a pencil icon, as specified in list-objects.html. So I am wondering, what would be the preferred approach to only make the comments clickable while not making other visual changes? I am open to any suggestions.

@nijel nijel added this to the 5.5 milestone Apr 2, 2024
@nijel nijel assigned nijel and BC46 Apr 2, 2024
Copy link

github-actions bot commented Apr 5, 2024

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. ux Issues related to user experience.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants