Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear documentation about screenshot discovery feature #9413

Closed
2 tasks done
surli opened this issue Jun 15, 2023 · 3 comments · Fixed by #9434
Closed
2 tasks done

Unclear documentation about screenshot discovery feature #9413

surli opened this issue Jun 15, 2023 · 3 comments · Fixed by #9434
Assignees
Labels
documentation Improvements or additions to the documentation.

Comments

@surli
Copy link
Contributor

surli commented Jun 15, 2023

Describe the issue

Hi,

I'm excited about the new feature for discovering automatically screenshots in a repo in 4.18 (thanks for that!) but the doc about it (in https://docs.weblate.org/en/latest/admin/projects.html#screenshot-file-mask) is not quite clear and we have a disagreement when talking about it.

So I just want to confirm: this is configured per component and the mask aims at matching a translation key, right?
For example if I have a component foo with a translation key my.translation.key and a mask /foo/translations/screenshots/*.png then it will search for /foo/translations/screenshots/my.translation.key.png. Is that correct?

I'll improve the doc with an example if it's right.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Read the documentation and discuss it.

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

PyPI module

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@surli surli added the question This is more a question for the support than an issue. label Jun 15, 2023
@github-actions
Copy link

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger.

In case your question is already answered, making a donation is the right way to say thank you!

@nijel nijel added documentation Improvements or additions to the documentation. and removed question This is more a question for the support than an issue. labels Jun 15, 2023
@nijel
Copy link
Member

nijel commented Jun 20, 2023

@surli Can you please review #9434?

@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants