PHP format is not aligned to sprintf

[matzeeable]

Describe the issue

When using the php-format check, it does not work with e.g. escaping.

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

The current regular expression does not work with escaped percent characters or spaces: https://regex101.com/r/kbxtub/1

weblate/weblate/checks/format.py

Lines 51 to 64 in fcd725b

	PHP_PRINTF_MATCH = re.compile(
	r"""
	%( # initial %
	(?:(?P<ord>\d+)\$)? # variable order, like %1$s
	(?P<fullvar>
	[ +#-]* # flags
	(?:\d+)? # width
	(?:\.\d+)? # precision
	(hh|h|l|ll)? # length formatting
	(?P<type>[a-zA-Z%]) # type (%s, %d, etc.)
	|) # incomplete format string
	)""",
	re.VERBOSE,
	)

Expected behavior

%% and % f should not be found as sprintf placeholder.

Screenshots

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

[nijel]

The check is correct because the ordering of the format strings have changed. Whatever was supposed to be printed as %d will be printed as %s with your translation.

[github-actions]

This issue has been marked as a question by a Weblate team member. Why? Because it belongs more to the professional Weblate Care or community Discussions than here. We strive to answer these reasonably fast here, too, but purchasing the support subscription is more responsible and faster for your business. And it makes Weblate stronger as well. Thanks!

In case your question is already answered, making a donation is the right way to say thank you!

[matzeeable]

Thanks for the prompt response. Changing to %1$s and %2$s seems to resolve the issue. But why is %% marked as variable? %% is an escaped %.

[nijel]

Because it is token processed by printf. Weblate will not complain if that is the only missing/extra one.

[github-actions]

The issue you have reported is now resolved. If you don’t feel it’s right, please follow its labels to get a clue for further steps.

• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.