Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some glossary terms are saved twice to TBX causing translations to disappear #9701

Open
2 tasks done
yilmazdurmaz opened this issue Aug 8, 2023 · 7 comments
Open
2 tasks done
Labels
bug Something is broken.
Milestone

Comments

@yilmazdurmaz
Copy link
Contributor

Describe the issue

There is no way to tell when this will happen. And I cannot trace who or what changes these. But happens in many languages at different times.

my translation is deleted today:
https://hosted.weblate.org/translate/godot-engine/glossary/tr/?checksum=ed18aa2599356aed&q=+changed%3A%3E%3D2023-07-08&sort_by=source

a chinese one deleted3 days ago:
https://hosted.weblate.org/translate/godot-engine/glossary/zh_Hans/?checksum=ed18aa2599356aed&q=+changed%3A%3E%3D2023-07-08&sort_by=source

As per a previous statement, I thought it could be a new addition to the English source, but there does not seem anything new there. besides, that should possibly be added as a duplicate.

I could only trace so far. I would say it might be related how translations propagates from components, but that does not tell anything about "deleting"

Please check the system and fix whatever causes the issue.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Seeming randomly happening. Only clue for me is the "None" username

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Aug 8, 2023

The problem seems caused by duplicate entries in the TBX file:

            <termEntry>
                <langSet xml:lang="en"><tig><term>Signals</term></tig></langSet>
                <langSet xml:lang="tr"><tig><term/></tig></langSet>
            </termEntry>
...
            <termEntry>
                <langSet xml:lang="en"><tig><term>Signals</term></tig></langSet>
                <langSet xml:lang="tr"><tig><term>Sinyaller, İşaretler</term></tig></langSet>
            </termEntry>

The question is how they appeared there.

@nijel nijel added the bug Something is broken. label Aug 8, 2023
@yilmazdurmaz
Copy link
Contributor Author

The problem seems caused by duplicate entries in the TBX file:

That is also interesting because if I search for that word, I get only 1 result: https://hosted.weblate.org/browse/godot-engine/glossary/tr/?q=Signals&sort_by=-priority%2Cposition&checksum=

@nijel
Copy link
Member

nijel commented Aug 9, 2023

That's expected, but it should trigger the duplicate string alert instead. Seems like there is some bug in processing TBX files.

@ngocanhtve
Copy link

I've also had a few deleted/edited by this "None" user.

@Cerno-b
Copy link

Cerno-b commented Nov 2, 2023

I can confirm that this is still a problem and not only occurs for adding or deleting a text, but also for editing. Is there any possible workaround until this is fixed?

@nijel nijel changed the title Rouge "None" user deletes Glossary translations on "hosted" Weblate Some glossary terms are saved twice to TBX causing translations to disappear Dec 21, 2023
@nijel nijel added this to the 5.4 milestone Dec 21, 2023
@nijel
Copy link
Member

nijel commented Dec 21, 2023

Workaround is to fix the TBX files manually to remove duplicate entries.

@nijel nijel modified the milestones: 5.4, 5.5 Feb 13, 2024
@nijel nijel modified the milestones: 5.5, 5.6 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

5 participants