Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize expression index for auth #9973

Closed
nijel opened this issue Sep 18, 2023 · 7 comments · Fixed by #10077
Closed

Utilize expression index for auth #9973

nijel opened this issue Sep 18, 2023 · 7 comments · Fixed by #10077
Assignees
@mohebmithani
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Milestone
5.1

Comments

@nijel
Copy link
Member

nijel commented Sep 18, 2023 •
edited
Loading

Describe the problem

Weblate does manually create index using CREATE UNIQUE INDEX during the weblate.auth model migration.

Describe the solution you'd like

This should be changed to use Django standard expression index UniqueConstraint(...Upper(...)) instead for better readability and portability.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

Need Django 4.0+ (Weblate already requires 4.2).

See also https://stackoverflow.com/a/69752763/225718 and https://stackoverflow.com/a/66966391/225718
@nijel nijel added enhancement Adding or requesting a new feature. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. labels Sep 18, 2023
@github-actions
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@nijel nijel changed the title Utilize expression index for Utilize expression index for auth Sep 18, 2023
@mohebmithani
Copy link
Contributor

Hi @nijel I would like to take this one for my first hacktoberfest contribution

@nijel
Copy link
Member Author

nijel commented Sep 21, 2023

You're welcome

@nishitiwari22
Copy link

Is this still open? I am looking to contribute to it I am newbie as well.

@mohebmithani
Copy link
Contributor

@nishitiwari22 i'm working on it. Apologies.

@mohebmithani mohebmithani mentioned this issue Oct 1, 2023
Merged
5 tasks
@mohebmithani
Copy link
Contributor

@nijel i've sent the PR. Let me know if it needs some changes

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@nijel nijel added this to the 5.1 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohebmithani mohebmithani

Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

refactor: Utilize expression index for auth mohebmithani/weblate
3 participants
@nijel @mohebmithani @nishitiwari22